Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for hOffset #8850

Merged
merged 1 commit into from
Sep 27, 2016
Merged

Account for hOffset #8850

merged 1 commit into from
Sep 27, 2016

Conversation

flyingL123
Copy link
Contributor

Currently if you set data-h-offset on a dropdown menu, the hoffset value is not used.

@rafibomb rafibomb added this to the 6.2.4 milestone Jul 12, 2016
@Owlbertz
Copy link
Contributor

Hi @flyingL123,
The Dropdown Menu component does not have a data-h-offset parameter. Maybe you are talking about the Dropdown component? However, unfortunately your PR does only fix this for LTR oriented sites. Can you adjust this so it will also work for RTL sites?

@kball
Copy link
Contributor

kball commented Sep 27, 2016

I'm going to go ahead and merge this for now - it looks like there are a number of positioning situations that don't take offsets properly into account right now, but we're planning on tackling positioning as a part of 6.2.5.

@kball kball merged commit 6c709a2 into foundation:develop Sep 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants