Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scrolling issue with reveal on ios #8744

Merged
merged 1 commit into from
May 11, 2016
Merged

Fix scrolling issue with reveal on ios #8744

merged 1 commit into from
May 11, 2016

Conversation

kball
Copy link
Contributor

@kball kball commented May 5, 2016

Fixes #8628 and #7548

@kball
Copy link
Contributor Author

kball commented May 5, 2016

@zurb/yetinauts anyone else with an ios device to test that can verify this and merge?

@designerno1
Copy link
Contributor

LGTM
Tested on my DEV Ipad 1

@Owlbertz
Copy link
Contributor

Owlbertz commented May 9, 2016

I checked with an iPhone 5 with the following results:

The close button's position is somewhat odd when there is a large heading:
image1

Scrolling inside the modal works much better now, but there is a small issue; the modal itself can be scrolled down by about 50px:

img_1432

@kball
Copy link
Contributor Author

kball commented May 11, 2016

@Owlbertz I could not find a way to disable the slight 'bounce' amount of scroll in the browser, only the general scroll... based on your feedback and @designerno1's I'm going to call this good enough because it moves the ball forward, though it would be nice to do further refinement.

@kball kball merged commit ceec8ad into develop May 11, 2016
@kball kball deleted the reveal-ios branch April 20, 2017 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants