Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change default behavior of tooltips #8730

Merged
merged 2 commits into from
May 4, 2016
Merged

change default behavior of tooltips #8730

merged 2 commits into from
May 4, 2016

Conversation

coreysyms
Copy link
Contributor

@coreysyms coreysyms commented May 3, 2016

In reference to #8697

This will change the default behavior of the tooltips to:

  • mouseenter = open
  • mouseleave = close
  • mouseclick = stay open / no toggle

@coreysyms
Copy link
Contributor Author

@kball, since you were the originator of #8697 can you verify this PR?

@designerno1
Copy link
Contributor

@coreysyms
with data-tip-hoverable set to true mouse over link opens tip hovering in span stays open as expected.
hovering back to the link the tip closes, shouldn't it stay open?

@designerno1
Copy link
Contributor

@coreysyms
as #8527 allowHtml is an option in v6.3

@coreysyms
Copy link
Contributor Author

@designerno1 I wrestled with this, and went back and forth on would a user navigate the mouse back and forth between the span and the tip, ultimately I felt that the cycle had to end somewhere so I left the tip close if you leave the tip, IE giving the power to the tip instead of the span, and in a sense, 'resetting' the cycle of what gets hovered.

As for the allowHTML option in 6.3, was using 'develop' as the master, and I didn't see that and can adhere to 6.3's behavior.

@coreysyms
Copy link
Contributor Author

hang loose on this, going to break these things in to 2 different PR's, one for the fix, one for the new feature

@coreysyms
Copy link
Contributor Author

ok, changed this PR to be just a bug fix to change the default behavior of the tooltip

@kball
Copy link
Contributor

kball commented May 4, 2016

OK fix looks good. Thanks @coreysyms

@kball kball merged commit 32264f8 into foundation:develop May 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants