Add possibility to disable slider after initialization.

[Owlbertz]

Slider will check for disabled state on every event now rather than only at its initialization.

Fixes #8497.

[ncoden]

Thanks. Should we check the [disabled=false] case ?

[Owlbertz]

Yeah, you're absolutely right. It only makes sense if you can also enable a disabled slider... Did another commit for this.

[ncoden]

I mean : should we consider the slider as enabled when it has a disabled="false" or disabled="enabled" attribute ?

[ncoden]

I don't know if this.options.disabled care about this cases, or if it is only checking that a disabled attribute has been set, regardless of its value

[Owlbertz]

I guess you mean data-disabled, since disabled is only for inputs. The options are only initialized once based on this attribute, so for now only checking the class is possible.

[ncoden]

var disabledAttr = this.$element.data('disabled');
var disabledClass = this.$element.hasClass(this.options.disabledClass);

if ((disabledClass || disabledAttr) && !(disabledAttr && disabledAttr == "false")) {

So :

• disabled class or attribute (not false) -> Disabled
• disabled option in initialization -> Disabled
• disabled option in initialization + disabled class or attribute (not false) -> Disabled
• disabled option in initialization + disabled class + disabled attribute equal to false -> Enabled

[kball]

I'd prefer there be a single source of truth, and it looks like we're currently using the class as the way to do that. @ncoden did you see someplace in particular that is setting data-disabled? I'm not seeing that mechanism being used.

[ncoden]

@kball this.options.enabled is initialized with $element.data.enabled

[kball]

@Owlbertz this looks good. Can you set up a unit test for this case in test/javascript/components/slider.js? You can use the tests in test/javascript/components/toggler.js as an example of how these can be structures. See: https://github.com/zurb/foundation-sites/blob/develop/test/javascript/components/toggler.js

Thanks!

[kball]

Gonna move forward with this