Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Css and Image To Buttons(Add Import Export) #1073

Closed
wants to merge 1 commit into from
Closed

Add Css and Image To Buttons(Add Import Export) #1073

wants to merge 1 commit into from

Conversation

hamedhossani
Copy link

It's easier to work with css style and icons.Without them I could hardly work.

It's easier to work with css style and icons.Without them I could hardly work.
@jtojnar
Copy link
Member

jtojnar commented Dec 11, 2018

What do you mean it to be easier to work with?

text-decoration:none;
color:#777;
margin-left:10px;
background: url(images/export.png) no-repeat left center #65a06c;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not really sure I want to add icons to imports and exports, since icons bring attention to things and I feel these action are used too rarely to warrant that.

.source-opml {
font-size:0.60em;
text-decoration:none;
color:#777;
margin-left:10px;
background: url(images/import.png) no-repeat left center #65a06c;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moreover we are working on rewriting the icons in #1013. It is just next in queue after #1014 and #1054.

@jtojnar
Copy link
Member

jtojnar commented May 3, 2020

Closing since there has been no activity.

@jtojnar jtojnar closed this May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants