Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support output of partial results #82

Merged
merged 2 commits into from
Feb 17, 2022
Merged

Conversation

adamhenson
Copy link
Collaborator

Summary

Bumps @foo-software/lighthouse-check to only output results when they exist. For example with 'onlyCategories': ['performance']' we should only output performance scores.

Issues

Upstream

@vercel
Copy link

vercel bot commented Feb 17, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/foo-software/lighthouse-check-action/EMkmQt75HrrupHAKcUPxpm6ErrYp
✅ Preview: https://lighthouse-check-action-git-fix-partial-output-foo-software.vercel.app

Copy link
Collaborator Author

@adamhenson adamhenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device Report URL
mobile report https://www.foo.software

Not what you expected? Are your scores flaky? Run Lighthouse on Foo

Copy link
Collaborator Author

@adamhenson adamhenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device Report URL
desktop report https://www.foo.software

Device Report URL
mobile report https://www.foo.software

Device Report URL
desktop report https://www.foo.software/tag/articles/

Device Report URL
mobile report https://www.foo.software/tag/articles/

Not what you expected? Are your scores flaky? Run Lighthouse on Foo
If scores continue to be inconsistent consider running all audits on Foo

@adamhenson adamhenson merged commit 7ca4ec4 into master Feb 17, 2022
@adamhenson adamhenson deleted the fix/partial-output branch February 17, 2022 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant