-
Notifications
You must be signed in to change notification settings - Fork 28.8k
Perf test for color filter with saveLayer #52063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This should reveal the problem in: flutter#51975 Fixing that issue should significantly lower the frame rasterization time.
@karhu: I've simplified your reproduction app, and put it inside Flutter's devicelab perf test suite. Do you think that you can directly create a PR like this next time? As for the two problem you mentioned,
|
dev/benchmarks/macrobenchmarks/lib/src/color_filter_and_fade.dart
Outdated
Show resolved
Hide resolved
@liyuqian Thanks a lot for your work on this! I went over your changes and it is indeed a great reference for future repro apps. Will definitely give it a try next time 👍 |
The use of the color param as a flag to trigger the use of shadow.color looks a little wonky, but that's not a blocking concern. LGTM. |
Oh, I see it. Now I've removed |
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of |
This should reveal the problem in:
#51975
Fixing that issue should significantly lower the frame rasterization
time.