Skip to content

Enable the verifier on the presubmits #8078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+46 −33
Open

Enable the verifier on the presubmits #8078

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/presubmit.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
strategy:
fail-fast: true
matrix:
bot: [CHECK_BOT, DART_BOT, UNIT_TEST_BOT]
bot: [CHECK_BOT, DART_BOT, UNIT_TEST_BOT, VERIFY_BOT]
steps:
- name: checkout
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/presubmit.yaml.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
strategy:
fail-fast: true
matrix:
bot: [CHECK_BOT, DART_BOT, UNIT_TEST_BOT]
bot: [CHECK_BOT, DART_BOT, UNIT_TEST_BOT, VERIFY_BOT]
steps:
- name: checkout
uses: actions/checkout@8f4b7f84864484a7bf31766abe9204da3cbe65b3
Expand Down
15 changes: 14 additions & 1 deletion tool/github.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,21 @@ elif [ "UNIT_TEST_BOT" = "$BOT" ] ; then
# Run unit tests.
./bin/plugin test --no-setup

else
elif [ "VERIFY_BOT" = "$BOT" ] ; then

# Before running gradlew verifyPlugin
echo "Checking permissions for /home/runner/"
ls -ld /home/runner/
echo "Creating .pluginVerifier/extracted-plugins directory if it doesn't exist..."
#mkdir -p /home/runner/.pluginVerifier
rm /home/runner/.pluginVerifier/extracted-plugins
echo "Checking permissions for /home/runner/.pluginVerifier"
ls -ld /home/runner/.pluginVerifier

# Run the vefifier for this version
./bin/plugin verify

else
# Run the build.
./bin/plugin make --channel=stable --only-version=$IDEA_VERSION --no-setup

Expand Down
60 changes: 30 additions & 30 deletions tool/plugin/lib/verify.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,36 +47,36 @@ class VerifyCommand extends ProductCommand {
// run './gradlew verifyPlugin'
var result = 0;
for (var spec in buildSpecs) {
log('\nverifyPluginProjectConfiguration for $spec:');
result = await runner.runGradleCommand(
['verifyPluginProjectConfiguration'],
spec,
'1',
'false',
);
if (result != 0) {
return result;
}
log('\nverifyPluginStructure for $spec:');
result = await runner.runGradleCommand(
['verifyPluginStructure'],
spec,
'1',
'false',
);
if (result != 0) {
return result;
}
log('\nverifyPluginSignature for $spec:');
result = await runner.runGradleCommand(
['verifyPluginSignature'],
spec,
'1',
'false',
);
if (result != 0) {
return result;
}
// log('\nverifyPluginProjectConfiguration for $spec:');
// result = await runner.runGradleCommand(
// ['verifyPluginProjectConfiguration'],
// spec,
// '1',
// 'false',
// );
// if (result != 0) {
// return result;
// }
// log('\nverifyPluginStructure for $spec:');
// result = await runner.runGradleCommand(
// ['verifyPluginStructure'],
// spec,
// '1',
// 'false',
// );
// if (result != 0) {
// return result;
// }
// log('\nverifyPluginSignature for $spec:');
// result = await runner.runGradleCommand(
// ['verifyPluginSignature'],
// spec,
// '1',
// 'false',
// );
// if (result != 0) {
// return result;
// }
log('\nverifyPlugin for $spec:');
result = await runner.runGradleCommand(
['verifyPlugin'],
Expand Down
Loading