Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add line#getGeometry and symbol#getGeometry #281

Merged
merged 12 commits into from
Jun 7, 2020
Merged

Add line#getGeometry and symbol#getGeometry #281

merged 12 commits into from
Jun 7, 2020

Conversation

m0nac0
Copy link
Collaborator

@m0nac0 m0nac0 commented May 24, 2020

As noted in #111, circle#getGeometry is already implemented, this implements the equivalents for lines and symbols.
Edit: on Android however, due to issue #130, symbols and lines are currently not draggable. Only the last annotation manager enabled in https://github.com/tobrun/flutter-mapbox-gl/blob/2339ab64c64ff75d544385ae16a35b3998dfc1be/android/src/main/java/com/mapbox/mapboxgl/MapboxMapController.java#L324-L326 supports dragging. I have tested this PR by changing the order of the annotation managers in these lines and getting the current position with the code from this PR worked.

Closes #111

@TimothySealy TimothySealy added ios and removed needs iOS labels Jun 5, 2020
@tobrun tobrun added this to the v0.8.0 milestone Jun 6, 2020
@m0nac0
Copy link
Collaborator Author

m0nac0 commented Jun 6, 2020

The CI failed, because pub would always get the platform_interface and web plugins from pub.dev and not use the local versions. I now changed that and the example app now always uses the local versions of these plugins.
I don't have any idea right now why flutter analyze fails, as the builds run fine and flutter analyze also finds no issues on my machine.

@m0nac0
Copy link
Collaborator Author

m0nac0 commented Jun 6, 2020

OK, the issue was that the CI was running flutter analyze in the top level directory, which still references the hosted plugins.
I changed the CI to analyze the example app, referencing the local versions of the plugins.

@m0nac0 m0nac0 merged commit 52091d7 into master Jun 7, 2020
@m0nac0 m0nac0 deleted the m0-get-geometry branch June 9, 2020 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Annotation#getGeometry
3 participants