Support RemoteDesktop.ConnectToEIS #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
whot
force-pushed
the
wip/remote-desktop-eis
branch
2 times, most recently
from
72ea745 to
0192ac1
Compare
|
You may want to cherry-pick ofourdan@9689ea23 as well |
|
done, thanks! |
whot
force-pushed
the
wip/remote-desktop-eis
branch
from
81d4aca to
3a02061
Compare
whot
force-pushed
the
wip/remote-desktop-eis
branch
from
3a02061 to
35fd732
Compare
These two portals are quite intertwined and the only reason the tests here passed was because the SC portal was missing and hence libportal never called select_sources, despite us selecting an XdpOutputType. Fix this by initializing both and adjusting the test accordingly.
whot
force-pushed
the
wip/remote-desktop-eis
branch
from
35fd732 to
883f389
Compare
|
This is now merged into xdg-desktop-portal (flatpak/xdg-desktop-portal#762) so let's mark this PR as ready. |
GeorgesStavracas
requested changes
Jul 18, 2023
This does not handle the niche case of an XDG portal providing either of ScreenCast or RemoteDesktop but not both.
Near identical checks, let's handle those through a helper function.
whot
force-pushed
the
wip/remote-desktop-eis
branch
from
883f389 to
ffbee46
Compare
This is intended to replace the various NotifyFoo dbus methods and instead connect the application with the implementation of the portal directly via a shared socket.
whot
force-pushed
the
wip/remote-desktop-eis
branch
from
ffbee46 to
422cb03
Compare
GeorgesStavracas
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See flatpak/xdg-desktop-portal#762
This adds support for connecting a remote desktop/screen cast session to an EIS implementation so the application and the EIS implementation (i.e. the compositor) can talk directly without having to bounce DBus messages through the portal.
cc @jadah, @ofourdah