Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Built without Pipewire support #22

Closed
wjt opened this issue Nov 19, 2020 · 3 comments
Closed

Built without Pipewire support #22

wjt opened this issue Nov 19, 2020 · 3 comments

Comments

@wjt
Copy link
Member

wjt commented Nov 19, 2020

Split from #21 because these things are not actually related.

Official Chrome binaries have a flag in chrome://flags/ to make Chrome use Pipewire to do screensharing on Wayland systems. This Flatpak of Chromium does not have that option. Based on NixOS/nixpkgs#89528, this needs rtc_use_pipewire=true build flag, and for libpipewire to be present. I do not know whether the libpipewire-0.3 in the SDK is usable by Chromium.

GeorgesStavracas added a commit to GeorgesStavracas/org.chromium.Chromium that referenced this issue Nov 19, 2020
Also allow the sandbox to talk to the xdg-run/pipewire-0 socket.

Fixes flathub#22
GeorgesStavracas added a commit to GeorgesStavracas/org.chromium.Chromium that referenced this issue Nov 19, 2020
Also allow the sandbox to talk to the xdg-run/pipewire-0 socket.

Fixes flathub#22
GeorgesStavracas added a commit to GeorgesStavracas/org.chromium.Chromium that referenced this issue Nov 19, 2020
Also allow the sandbox to talk to the xdg-run/pipewire-0 socket.

Fixes flathub#22
GeorgesStavracas added a commit to GeorgesStavracas/org.chromium.Chromium that referenced this issue Nov 19, 2020
Also allow the sandbox to talk to the xdg-run/pipewire-0 socket.

Fixes flathub#22
GeorgesStavracas added a commit to GeorgesStavracas/org.chromium.Chromium that referenced this issue Nov 19, 2020
Also allow the sandbox to talk to the xdg-run/pipewire-0 socket.

Fixes flathub#22
@refi64 refi64 closed this as completed in ec9c48b Nov 24, 2020
@tpopela
Copy link
Contributor

tpopela commented Dec 10, 2020

I note here. We will be able to drop the requirement on PipeWire 0.2 in Chromium 89. Or if you are not opposed for taking a temporary patch, you can backport the PipeWire 0.3 support with:

https://webrtc.googlesource.com/src/+/40c3ea5c7146cb7ec2fa999143d702b8825b725f
https://webrtc.googlesource.com/src/+/c3c81297365b6a293480f7af7ce5df632324b9e1

and ideally with https://chromium-review.googlesource.com/c/chromium/src/+/2578840 that should be merged soon (this will avoid the multiple dialogs (for previews and screen sharing itself).

One thing that could also be done would be to enable the PipeWire by default (by changing https://source.chromium.org/chromium/chromium/src/+/master:content/public/common/content_features.cc;l=975?q=kWebRtcPipeWireCapturer&ss=chromium)

@grulja
Copy link
Contributor

grulja commented Dec 10, 2020

Also, in case you backport support for PipeWire 0.3, you will have to specify rtc_pipewire_version = "0.3" as we default to "0.2".

@refi64
Copy link
Collaborator

refi64 commented Dec 11, 2020

Ah nice, unless it's a major user experience hit it would probably be better just to wait for upstream though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants