Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement LV based on paged WFS reading #133

Merged
merged 8 commits into from
Dec 10, 2024
Merged

Implement LV based on paged WFS reading #133

merged 8 commits into from
Dec 10, 2024

Conversation

ivorbosloper
Copy link
Collaborator

@ivorbosloper ivorbosloper commented Dec 3, 2024

Parse data from the original source (LV Government). This will allow us to add more years to the data collection (EuroCrops now only has 2021).

@ivorbosloper ivorbosloper requested a review from m-mohr December 3, 2024 14:51
@m-mohr m-mohr mentioned this pull request Dec 9, 2024
Copy link
Contributor

@m-mohr m-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog :-)

I'm inclined to create a PR template that asks to create a changelog entry ;-)

Co-authored-by: Matthias Mohr <[email protected]>
@ivorbosloper ivorbosloper requested a review from m-mohr December 9, 2024 14:01
@ivorbosloper
Copy link
Collaborator Author

Changelog :-)

I'm inclined to create a PR template that asks to create a changelog entry ;-)

I'd love that! For every PR that changes more than say 10 lines; changelog.md should contain a some change :)

@m-mohr
Copy link
Contributor

m-mohr commented Dec 9, 2024

I was more thinking of a checkbox in the PR description fields (similar to issue templates), but I guess a CI check also works (although a one line change could also be significant) ;-)

@ivorbosloper ivorbosloper merged commit 5bc2c90 into main Dec 10, 2024
2 checks passed
@ivorbosloper ivorbosloper deleted the lv branch December 10, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants