addpatch: system76-firmware 1.0.68-1 #4566
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xeonacid
requested changes
Feb 21, 2025
Comment on lines
+14
to
+15
| +#[cfg(any(target_arch = "x86", target_arch = "x86_64"))] | ||
| +use std::{io}; |
There was a problem hiding this comment.
Please leave some notes here. Why is it only used on x86? Should the change be upstreamed also?
Xeonacid
reviewed
Feb 21, 2025
gyx47
changed the title
gyx47
force-pushed
the
system76-firmware
branch
4 times, most recently
from
a2ebe2f to
b57ae7c
Compare
Xeonacid
reviewed
Feb 22, 2025
gyx47
force-pushed
the
system76-firmware
branch
from
d56d31b to
25dd2a1
Compare
|
Have you ever tried to cherry-pick pop-os/system76-firmware@090c09d? Seems to be a better way. |
|
I get it now, thanks for reminding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix io not used