Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check the TYPE parameter in a case-insensitive manner #386

Merged
merged 3 commits into from
Jan 4, 2023

Conversation

drakkan
Copy link
Collaborator

@drakkan drakkan commented Dec 4, 2022

according to RFC 959 section 3.1.1.4 local types will be sent as L 8, L 7 and so on, fixes that too.

See drakkan/sftpgo#1082

@codecov
Copy link

codecov bot commented Dec 4, 2022

Codecov Report

Base: 86.25% // Head: 86.25% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (d5b2fff) compared to base (d33ce00).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #386   +/-   ##
=======================================
  Coverage   86.25%   86.25%           
=======================================
  Files          11       11           
  Lines        1600     1601    +1     
=======================================
+ Hits         1380     1381    +1     
  Misses        152      152           
  Partials       68       68           
Impacted Files Coverage Δ
handle_misc.go 95.43% <100.00%> (+0.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@drakkan drakkan requested a review from fclairamb January 3, 2023 18:01
Copy link
Owner

@fclairamb fclairamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fclairamb fclairamb enabled auto-merge (squash) January 4, 2023 02:04
@fclairamb fclairamb merged commit 0b1a04e into fclairamb:main Jan 4, 2023
@drakkan
Copy link
Collaborator Author

drakkan commented Jan 4, 2023

Happy New Year and thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants