Config from code #749
Merged
Config from code #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's sometimes desirable to create a server that is configured by logic that creates the `Content`. Prior to this commit, such content needed to be written to a temporary file and then loaded into memory again in order to get a complete `Config`. This commit adds a `FromContent` method, allowing the `Config` to be created directly from a `Content`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only finishes #714 from @thallgren with a tiny lint fix:
It's sometimes desirable to create a server that is configured by logic that creates the Content. Before this commit, such content needed to be written to a temporary file and loaded into memory to get a complete Config.
This commit adds a FromContent method, allowing the Config to be created directly from Content.