Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Updated rust edition to 2024 #10

Merged
merged 3 commits into from
Feb 28, 2025
Merged

build: Updated rust edition to 2024 #10

merged 3 commits into from
Feb 28, 2025

Conversation

V-Fries
Copy link
Collaborator

@V-Fries V-Fries commented Feb 24, 2025

No description provided.

@V-Fries V-Fries requested a review from fan2bolide February 24, 2025 05:09
@V-Fries V-Fries self-assigned this Feb 24, 2025
@@ -1,7 +1,7 @@
use std::ffi::c_int;

#[link(name = "c")]
extern "C" {
unsafe extern "C" {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extern blocks must now be marked as unsafe

@V-Fries V-Fries marked this pull request as draft February 24, 2025 05:10
@V-Fries
Copy link
Collaborator Author

V-Fries commented Feb 24, 2025

The tests will keep failing till the rust version is updated in the GitHub actions. Let's wait for the update before merging.

Issue about the update: actions/runner-images#11637

@V-Fries V-Fries marked this pull request as ready for review February 28, 2025 03:27
@V-Fries V-Fries merged commit c44e231 into main Feb 28, 2025
3 checks passed
@V-Fries V-Fries deleted the build branch February 28, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants