Skip to content

Commit

Permalink
Enable RTTI to fix exception pointer issue on React Native (#1791)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #1791

Disabling RTTI for Yoga is causing std::exception to don't work properly in OSS.
Fixes: facebook/react-native#48027

Not sure why we originally disabled RTTI for Yoga, but we have it enable for the whole
React Native build so it probably makes sense to have it enabled for Yoga as well.

Changelog:
[Internal] [Changed] - Enable RTTI to fix exception pointer issue on React Native

bypass-github-export-checks

Reviewed By: javache, NickGerleman

Differential Revision: D70386744

fbshipit-source-id: 36e3a1ddb38346d31979d5c1b77d6e9796d6a855
  • Loading branch information
cortinico authored and facebook-github-bot committed Mar 4, 2025
1 parent 3aa594c commit 1b7d2c8
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions cmake/project-defaults.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ add_compile_options(
# Enable warnings and warnings as errors
/W4
/WX
# Disable RTTI
$<$<COMPILE_LANGUAGE:CXX>:/GR->
# Enable RTTI
$<$<COMPILE_LANGUAGE:CXX>:/GR>
# Use /O2 (Maximize Speed)
$<$<CONFIG:RELEASE>:/O2>)

Expand All @@ -34,8 +34,8 @@ add_compile_options(
# Enable warnings and warnings as errors
-Wall
-Werror
# Disable RTTI
$<$<COMPILE_LANGUAGE:CXX>:-fno-rtti>
# Enable RTTI
$<$<COMPILE_LANGUAGE:CXX>:-frtti>
# Use -O2 (prioritize speed)
$<$<CONFIG:RELEASE>:-O2>
# Enable separate sections per function/data item
Expand Down

0 comments on commit 1b7d2c8

Please sign in to comment.