[docs] Add missing sections to events reference page in IT and CN #5523
Conversation
| @@ -139,7 +139,6 @@ DOMEventTarget relatedTarget | |||
|
|
|||
| 이 포커스 이벤트는 폼 엘리먼트뿐만 아니라 모든 React DOM 엘리먼트에서 작동합니다. | |||
|
|
|||
| <a name="form-events"></a> | |||
There was a problem hiding this comment.
It used at docs/docs/07-forms.ko-KR.md:11 's link.
I want leave it as is.
<form>이벤트에 관한 정보는 폼 이벤트를 보세요.
There was a problem hiding this comment.
Section headers have anchors by default, can we use #폼-이벤트 anchor instead - without the need for hidden element?
There was a problem hiding this comment.
Since kramdown strip i18n characters.
http://facebook.github.io/react/docs/events-ko-KR.html#폼-이벤트
is not valid link.
Auto-generated link (http://facebook.github.io/react/docs/events-ko-KR.html#-) is pointing "이벤트 풀링".
You can check this behaviour on current page.
http://facebook.github.io/react/docs/events-ko-KR.html#-
There was a problem hiding this comment.
Same issue with http://facebook.github.io/react/docs/events-zh-CN.html. Is it a known limitation or issue of Jekyll ?
There was a problem hiding this comment.
You can read more at here.
There was a problem hiding this comment.
@marocchino wow, thanks! Good to know 👀
There was a problem hiding this comment.
We don't use Kramdown, we use Redcarpet. The header generation is done in a custom plugin (https://github.com/facebook/react/blob/master/docs/_plugins/header_links.rb) which is pretty naive (only supports a small number of characters).
When making changes like this, please run the server and ensure they work. This change won't work (as @marocchino said) without also changing how we generate the header links.
There was a problem hiding this comment.
Thanks @marocchino and @zpao for the details! I will remove this change here and keep it for another pull request once we know better solution.
|
🙆♀️ |
|
@hejld you should be all set! |
|
Awesome, thanks @claudiopro! |
hejld
force-pushed
the
add-selection-and-composition-events-on-reference-page
branch
from
8644723 to
1c20cea
Compare
|
@hejld updated the pull request. |
hejld
changed the title
|
np at all 👍 |
hejld
force-pushed
the
add-selection-and-composition-events-on-reference-page
branch
from
1c20cea to
18a3a39
Compare
|
@hejld updated the pull request. |
zpao
added
Component: Documentation & Website
and removed
GH Review: review-needed
labels
|
Thanks! |
…nts-on-reference-page [docs] Add missing sections to events reference page in IT and CN
…nts-on-reference-page [docs] Add missing sections to events reference page in IT and CN (cherry picked from commit 54e6057)
Fixes #432.
This PR adds missing parts of the events documentation to the respective Italian and Chinese translations. The english version was already done in #5142.
The translations are still WIP. Following section titles still need to be translated:
it-IT (done):
ko-KR:
zh-CN:
Could you guys help a bit? @minwe @marocchino @claudiopro
Thanks!