Use jsxc instead of commoner #2230
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 commoner seems to have more bugs than features in my experience. |
| ' $0 [src dir] [dest dir] (convert all files in src dir and write to dest dir)\n' + | ||
| ' $0 --extension .jsx [src dir] [src dir] (convert all .jsx files in src dir to .js)' + | ||
| ' $0 --watch [src dir] [dest dir] (watch src dir and place converted files in dest dir)\n' + | ||
| ' $0 --extension .jsx --watch [src dir] [src dir] (watch all .jsx files in src dir and convert to .js)' |
There was a problem hiding this comment.
Doesn't optimist take care of outputting options/usage?
There was a problem hiding this comment.
You need to provide usage yourself. It does describe all of the options. I wanted to put some common use cases in here to make the tool more usable.
|
Should we switch to recommending |
|
We're killing our tools so this is dead 💀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed several bug reports in the past few days on IRC. Still think commoner is the wrong tool for this job and jsxc is the right one.
Test plan: tested jsxc using the normal test plan. Ran bin/jsx, behaved same as jsxc