-
Notifications
You must be signed in to change notification settings - Fork 47.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Like button example verbiage #2146
Conversation
Changes text "You unlike this" to "You liked this". Makes a bit more grammatical sense.
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! |
Perhaps "don't like" would be more appropriate. |
Yeah neither really make sense actually. There should be a 3rd state where you're neutral about it. |
"haven't liked"? |
Ok, updated PR. |
Do you mind signing the CLA? Once you do I'll merge this. |
No prob, done! On Thu, Sep 4, 2014 at 2:13 PM, Ben Alpert [email protected] wrote:
Nick Merwin |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Thanks! |
Changes text "You unlike this" to "You liked this". Makes a bit more grammatical sense.