[Synchronous Suspense] Suspending a class outside concurrent mode #13926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a class component suspends during mount outside concurrent mode, change the tag so it's not mistaken for a completed component. For example, we should not call componentWillUnmount if it is deleted.
sebmarkbage
approved these changes
Oct 23, 2018
sebmarkbage
reviewed
Oct 23, 2018
|
@sebmarkbage Re: naming, I thought maybe this might be needed for other types in the future? But I suppose we'll rename it then. |
acdlite
force-pushed
the
mounting-incomplete-classes
branch
from
b2e52a9 to
e1300ef
Compare
gaearon
reviewed
Oct 23, 2018
| // Typically, a component that mounted will have an instance. However, | ||
| // outside of concurrent mode, a suspended component may commit without | ||
| // an instance, so we need to check whether it exists. | ||
| instance !== null && |
There was a problem hiding this comment.
So why do we still need this check? I thought the separate tag is supposed to address it.
aweary
reviewed
Oct 23, 2018
| @@ -762,7 +763,7 @@ function mountLazyComponent( | |||
| renderExpirationTime, | |||
| ) { | |||
| if (_current !== null) { | |||
| // An indeterminate component only mounts if it suspended inside a non- | |||
| // An lazy component only mounts if it suspended inside a non- | |||
| ) { | ||
| if (_current !== null) { | ||
| // An incomplete component only mounts if it suspended inside a non- | ||
| // concurrent tree, in an inconsistent state. We want to tree it like |
There was a problem hiding this comment.
We want to tree it
treat it?
|
ReactDOM: size: 🔺+0.3%, gzip: 🔺+0.3% Details of bundled changes.Comparing: 4947fcd...e1300ef react-dom
react-art
react-test-renderer
react-reconciler
react-native-renderer
scheduler
Generated by 🚫 dangerJS |
jetoneza
pushed a commit
to jetoneza/react
that referenced
this pull request
Jan 23, 2019
…cebook#13926) * [Synchronous Suspense] Suspending a class outside concurrent mode When a class component suspends during mount outside concurrent mode, change the tag so it's not mistaken for a completed component. For example, we should not call componentWillUnmount if it is deleted. * PR nits
NMinhNguyen
referenced
this pull request
in enzymejs/react-shallow-renderer
Jan 29, 2020
…3926) * [Synchronous Suspense] Suspending a class outside concurrent mode When a class component suspends during mount outside concurrent mode, change the tag so it's not mistaken for a completed component. For example, we should not call componentWillUnmount if it is deleted. * PR nits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a class component suspends during mount outside concurrent mode, change the tag so it's not mistaken for a completed component. For example, we should not call componentWillUnmount if it is deleted.