Skip to content

Commit

Permalink
[DevTools] Use Unicode Atom Symbol instead of Atom Emoji (#30832)
Browse files Browse the repository at this point in the history
This reverts #19603.

Before:
<img width="724" alt="Screenshot 2024-08-28 at 12 07 29 AM"
src="https://github.com/user-attachments/assets/0613088f-c013-4f1c-92c3-fbdae8c1f109">

After:
<img width="771" alt="Screenshot 2024-08-28 at 12 08 13 AM"
src="https://github.com/user-attachments/assets/eef21bee-d11f-4f0a-9147-053a163f720f">

Consensus seems to be that while the purple on is a bit clearer and
easier to read. The purple is not on brand so it doesn't look like
React. It looks ugly. It's distracting (too eye catching). Taking away
attention from other tabs in an unfair way.

It also gets worse with more tabs added. We plan on both adding another
tab and panes inside other tabs (elements/sources) soon. Each needs to
be marked somehow as part of React but spelling it out is too long.
Putting inside a second tab means two clicks and takes away real-estate
from our extension and doesn't solve the problem with extension panes in
other tabs. We also plan on adding multiple different tracks to the
Performance tab which also needs a name other than just React and
spelling out React as a prefix is too long. The Emoji is too
distracting. So it seems best to uniformly apply the symbol - albeit it
might just look like a dot to many.

Dark mode looks close to on brand:

<img width="1089" alt="Screenshot 2024-08-28 at 12 32 50 AM"
src="https://github.com/user-attachments/assets/7175a540-4241-4c26-9e4d-4d367873af57">

DiffTrain build for [d160aa0](d160aa0)
  • Loading branch information
sebmarkbage committed Sep 10, 2024
1 parent eb67bf1 commit 4d30e52
Show file tree
Hide file tree
Showing 34 changed files with 158 additions and 158 deletions.
2 changes: 1 addition & 1 deletion compiled/facebook-www/REVISION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
727b3615287074ddaa28069bfbd2dfee8cf73575
d160aa0fbb1bd2d00ea8c771c551c9cb5b47f1e9
2 changes: 1 addition & 1 deletion compiled/facebook-www/REVISION_TRANSFORMS
Original file line number Diff line number Diff line change
@@ -1 +1 @@
727b3615287074ddaa28069bfbd2dfee8cf73575
d160aa0fbb1bd2d00ea8c771c551c9cb5b47f1e9
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -2001,7 +2001,7 @@ __DEV__ &&
exports.useTransition = function () {
return resolveDispatcher().useTransition();
};
exports.version = "19.0.0-www-classic-727b3615-20240906";
exports.version = "19.0.0-www-classic-d160aa0f-20240910";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -1981,7 +1981,7 @@ __DEV__ &&
exports.useTransition = function () {
return resolveDispatcher().useTransition();
};
exports.version = "19.0.0-www-modern-727b3615-20240906";
exports.version = "19.0.0-www-modern-d160aa0f-20240910";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -665,4 +665,4 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactSharedInternals.H.useTransition();
};
exports.version = "19.0.0-www-classic-727b3615-20240906";
exports.version = "19.0.0-www-classic-d160aa0f-20240910";
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -665,4 +665,4 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactSharedInternals.H.useTransition();
};
exports.version = "19.0.0-www-modern-727b3615-20240906";
exports.version = "19.0.0-www-modern-d160aa0f-20240910";
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-profiling.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -669,7 +669,7 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactSharedInternals.H.useTransition();
};
exports.version = "19.0.0-www-classic-727b3615-20240906";
exports.version = "19.0.0-www-classic-d160aa0f-20240910";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-profiling.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -669,7 +669,7 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactSharedInternals.H.useTransition();
};
exports.version = "19.0.0-www-modern-727b3615-20240906";
exports.version = "19.0.0-www-modern-d160aa0f-20240910";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
24 changes: 12 additions & 12 deletions compiled/facebook-www/ReactART-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -1442,7 +1442,7 @@ __DEV__ &&
var id = getWakeableID(wakeable),
display = wakeable.displayName || wakeable;
log(
"%c\u269b\ufe0f%c " + componentName + " suspended",
"%c\u269b%c " + componentName + " suspended",
"background-color: #20232a; color: #61dafb; padding: 0 2px;",
"color: #80366d; font-weight: bold;",
id,
Expand All @@ -1451,7 +1451,7 @@ __DEV__ &&
wakeable.then(
function () {
log(
"%c\u269b\ufe0f%c " + componentName + " resolved",
"%c\u269b%c " + componentName + " resolved",
"background-color: #20232a; color: #61dafb; padding: 0 2px;",
"color: #80366d; font-weight: bold;",
id,
Expand All @@ -1460,7 +1460,7 @@ __DEV__ &&
},
function () {
log(
"%c\u269b\ufe0f%c " + componentName + " rejected",
"%c\u269b%c " + componentName + " rejected",
"background-color: #20232a; color: #61dafb; padding: 0 2px;",
"color: #80366d; font-weight: bold;",
id,
Expand All @@ -1473,7 +1473,7 @@ __DEV__ &&
function logRenderStarted(lanes) {
enableDebugTracing &&
group(
"%c\u269b\ufe0f%c render%c (" + formatLanes(lanes) + ")",
"%c\u269b%c render%c (" + formatLanes(lanes) + ")",
"background-color: #20232a; color: #61dafb; padding: 0 2px;",
"",
"font-weight: normal;"
Expand All @@ -1482,7 +1482,7 @@ __DEV__ &&
function logStateUpdateScheduled(componentName, lane, payloadOrAction) {
enableDebugTracing &&
log(
"%c\u269b\ufe0f%c " +
"%c\u269b%c " +
componentName +
" updated state %c(" +
formatLanes(lane) +
Expand Down Expand Up @@ -13428,7 +13428,7 @@ __DEV__ &&
enableDebugTracing &&
enableDebugTracing &&
group(
"%c\u269b\ufe0f%c commit%c (" + formatLanes(lanes) + ")",
"%c\u269b%c commit%c (" + formatLanes(lanes) + ")",
"background-color: #20232a; color: #61dafb; padding: 0 2px;",
"",
"font-weight: normal;"
Expand Down Expand Up @@ -13489,7 +13489,7 @@ __DEV__ &&
enableDebugTracing &&
enableDebugTracing &&
group(
"%c\u269b\ufe0f%c layout effects%c (" + formatLanes(lanes) + ")",
"%c\u269b%c layout effects%c (" + formatLanes(lanes) + ")",
"background-color: #20232a; color: #61dafb; padding: 0 2px;",
"",
"font-weight: normal;"
Expand Down Expand Up @@ -13624,7 +13624,7 @@ __DEV__ &&
enableDebugTracing &&
enableDebugTracing &&
group(
"%c\u269b\ufe0f%c passive effects%c (" + formatLanes(lanes) + ")",
"%c\u269b%c passive effects%c (" + formatLanes(lanes) + ")",
"background-color: #20232a; color: #61dafb; padding: 0 2px;",
"",
"font-weight: normal;"
Expand Down Expand Up @@ -16532,7 +16532,7 @@ __DEV__ &&
((callback = getComponentNameFromFiber(inst) || "Unknown"),
enableDebugTracing &&
log(
"%c\u269b\ufe0f%c " +
"%c\u269b%c " +
callback +
" forced update %c(" +
formatLanes(lane) +
Expand Down Expand Up @@ -16964,11 +16964,11 @@ __DEV__ &&
(function () {
var internals = {
bundleType: 1,
version: "19.0.0-www-classic-727b3615-20240906",
version: "19.0.0-www-classic-d160aa0f-20240910",
rendererPackageName: "react-art",
currentDispatcherRef: ReactSharedInternals,
findFiberByHostInstance: getInstanceFromNode,
reconcilerVersion: "19.0.0-www-classic-727b3615-20240906"
reconcilerVersion: "19.0.0-www-classic-d160aa0f-20240910"
};
internals.overrideHookState = overrideHookState;
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
Expand Down Expand Up @@ -17002,7 +17002,7 @@ __DEV__ &&
exports.Shape = Shape;
exports.Surface = Surface;
exports.Text = Text;
exports.version = "19.0.0-www-classic-727b3615-20240906";
exports.version = "19.0.0-www-classic-d160aa0f-20240910";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
24 changes: 12 additions & 12 deletions compiled/facebook-www/ReactART-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -1331,7 +1331,7 @@ __DEV__ &&
var id = getWakeableID(wakeable),
display = wakeable.displayName || wakeable;
log(
"%c\u269b\ufe0f%c " + componentName + " suspended",
"%c\u269b%c " + componentName + " suspended",
"background-color: #20232a; color: #61dafb; padding: 0 2px;",
"color: #80366d; font-weight: bold;",
id,
Expand All @@ -1340,7 +1340,7 @@ __DEV__ &&
wakeable.then(
function () {
log(
"%c\u269b\ufe0f%c " + componentName + " resolved",
"%c\u269b%c " + componentName + " resolved",
"background-color: #20232a; color: #61dafb; padding: 0 2px;",
"color: #80366d; font-weight: bold;",
id,
Expand All @@ -1349,7 +1349,7 @@ __DEV__ &&
},
function () {
log(
"%c\u269b\ufe0f%c " + componentName + " rejected",
"%c\u269b%c " + componentName + " rejected",
"background-color: #20232a; color: #61dafb; padding: 0 2px;",
"color: #80366d; font-weight: bold;",
id,
Expand All @@ -1362,7 +1362,7 @@ __DEV__ &&
function logRenderStarted(lanes) {
enableDebugTracing &&
group(
"%c\u269b\ufe0f%c render%c (" + formatLanes(lanes) + ")",
"%c\u269b%c render%c (" + formatLanes(lanes) + ")",
"background-color: #20232a; color: #61dafb; padding: 0 2px;",
"",
"font-weight: normal;"
Expand All @@ -1371,7 +1371,7 @@ __DEV__ &&
function logStateUpdateScheduled(componentName, lane, payloadOrAction) {
enableDebugTracing &&
log(
"%c\u269b\ufe0f%c " +
"%c\u269b%c " +
componentName +
" updated state %c(" +
formatLanes(lane) +
Expand Down Expand Up @@ -12972,7 +12972,7 @@ __DEV__ &&
enableDebugTracing &&
enableDebugTracing &&
group(
"%c\u269b\ufe0f%c commit%c (" + formatLanes(lanes) + ")",
"%c\u269b%c commit%c (" + formatLanes(lanes) + ")",
"background-color: #20232a; color: #61dafb; padding: 0 2px;",
"",
"font-weight: normal;"
Expand Down Expand Up @@ -13033,7 +13033,7 @@ __DEV__ &&
enableDebugTracing &&
enableDebugTracing &&
group(
"%c\u269b\ufe0f%c layout effects%c (" + formatLanes(lanes) + ")",
"%c\u269b%c layout effects%c (" + formatLanes(lanes) + ")",
"background-color: #20232a; color: #61dafb; padding: 0 2px;",
"",
"font-weight: normal;"
Expand Down Expand Up @@ -13166,7 +13166,7 @@ __DEV__ &&
enableDebugTracing &&
enableDebugTracing &&
group(
"%c\u269b\ufe0f%c passive effects%c (" + formatLanes(lanes) + ")",
"%c\u269b%c passive effects%c (" + formatLanes(lanes) + ")",
"background-color: #20232a; color: #61dafb; padding: 0 2px;",
"",
"font-weight: normal;"
Expand Down Expand Up @@ -15979,7 +15979,7 @@ __DEV__ &&
((callback = getComponentNameFromFiber(inst) || "Unknown"),
enableDebugTracing &&
log(
"%c\u269b\ufe0f%c " +
"%c\u269b%c " +
callback +
" forced update %c(" +
formatLanes(lane) +
Expand Down Expand Up @@ -16410,11 +16410,11 @@ __DEV__ &&
(function () {
var internals = {
bundleType: 1,
version: "19.0.0-www-modern-727b3615-20240906",
version: "19.0.0-www-modern-d160aa0f-20240910",
rendererPackageName: "react-art",
currentDispatcherRef: ReactSharedInternals,
findFiberByHostInstance: getInstanceFromNode,
reconcilerVersion: "19.0.0-www-modern-727b3615-20240906"
reconcilerVersion: "19.0.0-www-modern-d160aa0f-20240910"
};
internals.overrideHookState = overrideHookState;
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
Expand Down Expand Up @@ -16448,7 +16448,7 @@ __DEV__ &&
exports.Shape = Shape;
exports.Surface = Surface;
exports.Text = Text;
exports.version = "19.0.0-www-modern-727b3615-20240906";
exports.version = "19.0.0-www-modern-d160aa0f-20240910";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
6 changes: 3 additions & 3 deletions compiled/facebook-www/ReactART-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -10781,13 +10781,13 @@ var slice = Array.prototype.slice,
})(React.Component);
var internals$jscomp$inline_1422 = {
bundleType: 0,
version: "19.0.0-www-classic-727b3615-20240906",
version: "19.0.0-www-classic-d160aa0f-20240910",
rendererPackageName: "react-art",
currentDispatcherRef: ReactSharedInternals,
findFiberByHostInstance: function () {
return null;
},
reconcilerVersion: "19.0.0-www-classic-727b3615-20240906"
reconcilerVersion: "19.0.0-www-classic-d160aa0f-20240910"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1423 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand All @@ -10813,4 +10813,4 @@ exports.RadialGradient = RadialGradient;
exports.Shape = TYPES.SHAPE;
exports.Surface = Surface;
exports.Text = Text;
exports.version = "19.0.0-www-classic-727b3615-20240906";
exports.version = "19.0.0-www-classic-d160aa0f-20240910";
6 changes: 3 additions & 3 deletions compiled/facebook-www/ReactART-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -10295,13 +10295,13 @@ var slice = Array.prototype.slice,
})(React.Component);
var internals$jscomp$inline_1414 = {
bundleType: 0,
version: "19.0.0-www-modern-727b3615-20240906",
version: "19.0.0-www-modern-d160aa0f-20240910",
rendererPackageName: "react-art",
currentDispatcherRef: ReactSharedInternals,
findFiberByHostInstance: function () {
return null;
},
reconcilerVersion: "19.0.0-www-modern-727b3615-20240906"
reconcilerVersion: "19.0.0-www-modern-d160aa0f-20240910"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1415 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand All @@ -10327,4 +10327,4 @@ exports.RadialGradient = RadialGradient;
exports.Shape = TYPES.SHAPE;
exports.Surface = Surface;
exports.Text = Text;
exports.version = "19.0.0-www-modern-727b3615-20240906";
exports.version = "19.0.0-www-modern-d160aa0f-20240910";
Loading

0 comments on commit 4d30e52

Please sign in to comment.