Add description and update value diff check for input range

facebook · May 30, 2018 · 1684cfc · 1684cfc
1 parent 3203e0e
commit 1684cfc
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/packages/react-dom/src/client/ReactDOMFiberInput.js b/packages/react-dom/src/client/ReactDOMFiberInput.js
@@ -210,6 +210,10 @@ export function postMountWrapper(element: Element, props: Object) {
 
   if (props.hasOwnProperty('value') || props.hasOwnProperty('defaultValue')) {
     const initialValue = '' + node._wrapperState.initialValue;
+
+    // With range inputs node.value may be a default value calculated from the
+    // min/max attributes. This ensures that node.value is set with the correct
+    // value coming from props.
     const currentValue = props.type === 'range' ? '' : node.value;
 
     // Do not assign value if it is already set. This prevents user text input
@@ -220,6 +224,8 @@ export function postMountWrapper(element: Element, props: Object) {
       // prematurely marking required inputs as invalid
       if (initialValue !== currentValue) {
         node.value = initialValue;
+      } else if (props.type === 'range') {
+        node.value = initialValue;
       }
     }