Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate react Android tests to Robolectric v4 #28927

Closed
wants to merge 1 commit into from
Closed

Migrate react Android tests to Robolectric v4 #28927

wants to merge 1 commit into from

Conversation

jselbo
Copy link

@jselbo jselbo commented May 19, 2020

Summary:
Changelog:
[Android] Test Modernization

Differential Revision: D21598788

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported labels May 19, 2020
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D21598788

@pull-bot
Copy link

pull-bot commented May 19, 2020 •
edited
Loading

Messages
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.
📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖 📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against ae68955

@analysis-bot
Copy link

analysis-bot commented May 19, 2020 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
ios - universal 10,747,088 9,937,520

Base commit: 8b2eb37

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D21598788

16 similar comments
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D21598788

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D21598788

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D21598788

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D21598788

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D21598788

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D21598788

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D21598788

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D21598788

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D21598788

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D21598788

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D21598788

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D21598788

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D21598788

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D21598788

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D21598788

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D21598788

@analysis-bot
Copy link

analysis-bot commented May 21, 2020 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 6,780,718 0
android hermes armeabi-v7a 6,442,968 0
android hermes x86 7,165,834 0
android hermes x86_64 7,056,521 0
android jsc arm64-v8a 8,948,503 0
android jsc armeabi-v7a 8,603,150 0
android jsc x86 8,776,758 0
android jsc x86_64 9,353,043 0

Base commit: 8b2eb37

@facebook-github-bot
Migrate react-native Android tests to Robolectric v4 (#28927)
ae68955 
Summary:
Pull Request resolved: #28927

Changelog:
[Android] [Changed] Test Modernization

Reviewed By: mdvacca

Differential Revision: D21598788

fbshipit-source-id: ae90def83764b557a9d89ef2fcd09048b6e1e112
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D21598788

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by Joshua Selbo in 6a78b32.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jselbo @facebook-github-bot @pull-bot @analysis-bot @react-native-bot