Sync React with Haste-style imports rewritten to use path-based imports instead #25100

ide · 2019-05-31T03:48:04Z

Summary

This is a manual React sync to replace Haste names with paths so that the removal of Haste is not blocked on a normal React sync. This is a one-time special case; in the future, React will generate renderers that use paths instead of Haste.

This commit uses the same base commit of React that's currently in RN (React ec6691a68716bc59291746fc62f374a56fb435c9) plus a commit in the React repo that removes Haste-style imports from the renderer (61f62246c8cfb76a4a19d1661eeaa5822ec37b36) and a commit to make the shims import from implementations (facebook/react#15786).

I built React in the React repo with yarn build and copied over the oss directory into one called implementations and removed the *.fb.js files.

Changelog

[General] [Changed] - Sync React with Haste-style imports rewritten to use path-based imports instead

Test Plan

Run unit tests, RNTester, CI. Also verified that we can make Metro pick up .fb.js files with:

resolver: {
  sourceExts: ['fb.js', 'js', 'json', ...],
}

…ts instead This commit uses the same base commit of React that's currently in RN (React ec6691a68716bc59291746fc62f374a56fb435c9) plus a commit in the React repo that removes Haste-style imports from the renderer and a commit to make the shims import from `implementations` (facebook/react#15786). I built React in the React repo with `yarn build` and copied over the `oss` directory into one called `implementations` and removed the `*.fb.js` files. Test plan: run unit tests, RNTester, CI. Also verified that we can make Metro pick up `.fb.js` files with: ```js resolver: { sourceExts: ['fb.js', 'js', 'json', ...], } ```

cpojer

Let me import it.

facebook-github-bot

@cpojer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

react-native-bot · 2019-06-05T11:25:05Z

This pull request was successfully merged by @ide in 69d1ed7.

^{When will my fix make it into a release? | Upcoming Releases}

…facebook#24811) Summary: **Depends on facebook#25100 This commit depends on having migrated all of RN away from Haste. With 100% standard path-based requires, the key foundation is set and we no longer need `hasteImpl` and related settings in the Jest configuration. This commit deletes the `hasteImpl` file and setting as well as `providesModuleNodeModules` and `modulePathNameMapper`, removing most of the dependency graph overriding performed by Jest. ## Changelog [General] [Changed] - Delete hasteImpl, providesModuleNodeModules, and modulePathNameMapper from Jest config Pull Request resolved: facebook#24811 Differential Revision: D15659274 Pulled By: cpojer fbshipit-source-id: 8a4a3b97ddf7e38fbe62c6d3cc9c98248bfca343

Summary: **Depends on #25100 This is one of the steps unlocked by migrating RN from Haste to path-based imports. This commit sets Flow to use path-based imports by removing all of the Haste-related configuration options. Additionally, it maps `react-native` to import from within this module to match Node's module resolution behavior. It also adds `<PROJECT_ROOT>` to the image name mapper so that the mapped name doesn't rely on Haste. ## Changelog [General] [Changed] - Make Flow configs use path-based imports instead of Haste Pull Request resolved: #24812 Differential Revision: D15659189 Pulled By: cpojer fbshipit-source-id: d0efaa2884485a492dcdef8d94061129cebc2566

…ts instead (facebook#25100) Summary: **This is a manual React sync to replace Haste names with paths so that the removal of Haste is not blocked on a normal React sync. This is a one-time special case; in the future, React will generate renderers that use paths instead of Haste.** This commit uses the same base commit of React that's currently in RN (React ec6691a68716bc59291746fc62f374a56fb435c9) plus a commit in the React repo that removes Haste-style imports from the renderer (61f62246c8cfb76a4a19d1661eeaa5822ec37b36) and a commit to make the shims import from `implementations` (facebook/react#15786). I built React in the React repo with `yarn build` and copied over the `oss` directory into one called `implementations` and removed the `*.fb.js` files. ## Changelog [General] [Changed] - Sync React with Haste-style imports rewritten to use path-based imports instead Pull Request resolved: facebook#25100 Reviewed By: yungsters Differential Revision: D15575646 Pulled By: cpojer fbshipit-source-id: adf25f9826b71729043b65ba1afd20d14d8c19c4 (cherry picked from commit 69d1ed7)

…facebook#24811) Summary: **Depends on facebook#25100 This commit depends on having migrated all of RN away from Haste. With 100% standard path-based requires, the key foundation is set and we no longer need `hasteImpl` and related settings in the Jest configuration. This commit deletes the `hasteImpl` file and setting as well as `providesModuleNodeModules` and `modulePathNameMapper`, removing most of the dependency graph overriding performed by Jest. ## Changelog [General] [Changed] - Delete hasteImpl, providesModuleNodeModules, and modulePathNameMapper from Jest config Pull Request resolved: facebook#24811 Differential Revision: D15659274 Pulled By: cpojer fbshipit-source-id: 8a4a3b97ddf7e38fbe62c6d3cc9c98248bfca343 (cherry picked from commit 7a2463e)

…4812) Summary: **Depends on facebook#25100 This is one of the steps unlocked by migrating RN from Haste to path-based imports. This commit sets Flow to use path-based imports by removing all of the Haste-related configuration options. Additionally, it maps `react-native` to import from within this module to match Node's module resolution behavior. It also adds `<PROJECT_ROOT>` to the image name mapper so that the mapped name doesn't rely on Haste. ## Changelog [General] [Changed] - Make Flow configs use path-based imports instead of Haste Pull Request resolved: facebook#24812 Differential Revision: D15659189 Pulled By: cpojer fbshipit-source-id: d0efaa2884485a492dcdef8d94061129cebc2566 (cherry picked from commit bf8d918)

…ts instead (#25100) Summary: **This is a manual React sync to replace Haste names with paths so that the removal of Haste is not blocked on a normal React sync. This is a one-time special case; in the future, React will generate renderers that use paths instead of Haste.** This commit uses the same base commit of React that's currently in RN (React ec6691a68716bc59291746fc62f374a56fb435c9) plus a commit in the React repo that removes Haste-style imports from the renderer (61f62246c8cfb76a4a19d1661eeaa5822ec37b36) and a commit to make the shims import from `implementations` (facebook/react#15786). I built React in the React repo with `yarn build` and copied over the `oss` directory into one called `implementations` and removed the `*.fb.js` files. ## Changelog [General] [Changed] - Sync React with Haste-style imports rewritten to use path-based imports instead Pull Request resolved: facebook/react-native#25100 Reviewed By: yungsters Differential Revision: D15575646 Pulled By: cpojer fbshipit-source-id: adf25f9826b71729043b65ba1afd20d14d8c19c4

…ts instead (facebook#25100) Summary: **This is a manual React sync to replace Haste names with paths so that the removal of Haste is not blocked on a normal React sync. This is a one-time special case; in the future, React will generate renderers that use paths instead of Haste.** This commit uses the same base commit of React that's currently in RN (React ec6691a68716bc59291746fc62f374a56fb435c9) plus a commit in the React repo that removes Haste-style imports from the renderer (61f62246c8cfb76a4a19d1661eeaa5822ec37b36) and a commit to make the shims import from `implementations` (facebook/react#15786). I built React in the React repo with `yarn build` and copied over the `oss` directory into one called `implementations` and removed the `*.fb.js` files. ## Changelog [General] [Changed] - Sync React with Haste-style imports rewritten to use path-based imports instead Pull Request resolved: facebook#25100 Reviewed By: yungsters Differential Revision: D15575646 Pulled By: cpojer fbshipit-source-id: adf25f9826b71729043b65ba1afd20d14d8c19c4

…facebook#24811) Summary: **Depends on facebook#25100 This commit depends on having migrated all of RN away from Haste. With 100% standard path-based requires, the key foundation is set and we no longer need `hasteImpl` and related settings in the Jest configuration. This commit deletes the `hasteImpl` file and setting as well as `providesModuleNodeModules` and `modulePathNameMapper`, removing most of the dependency graph overriding performed by Jest. ## Changelog [General] [Changed] - Delete hasteImpl, providesModuleNodeModules, and modulePathNameMapper from Jest config Pull Request resolved: facebook#24811 Differential Revision: D15659274 Pulled By: cpojer fbshipit-source-id: 8a4a3b97ddf7e38fbe62c6d3cc9c98248bfca343

…4812) Summary: **Depends on facebook#25100 This is one of the steps unlocked by migrating RN from Haste to path-based imports. This commit sets Flow to use path-based imports by removing all of the Haste-related configuration options. Additionally, it maps `react-native` to import from within this module to match Node's module resolution behavior. It also adds `<PROJECT_ROOT>` to the image name mapper so that the mapped name doesn't rely on Haste. ## Changelog [General] [Changed] - Make Flow configs use path-based imports instead of Haste Pull Request resolved: facebook#24812 Differential Revision: D15659189 Pulled By: cpojer fbshipit-source-id: d0efaa2884485a492dcdef8d94061129cebc2566

Part of the RN v0.60 -> v0.61 changes to the template app [1], corresponding to facebook/react-native@bf8d91868 and a correction in facebook/react-native@732ded7f7. This must happen at or after the main upgrade commit because the former declares that it depends on facebook/react-native#25100, which landed in facebook/react-native@69d1ed731 and was released in v0.61.0. [1]: https://react-native-community.github.io/upgrade-helper/?from=0.60.6&to=0.61.5

ide requested a review from cpojer May 31, 2019 03:48

facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Expo Partner: Expo Partner labels May 31, 2019

ide mentioned this pull request May 31, 2019

[standards] Umbrella issue to track migration to standard path-based requires (remove Haste) #24316

Closed

12 tasks

cpojer approved these changes May 31, 2019

View reviewed changes

facebook-github-bot reviewed May 31, 2019

View reviewed changes

This was referenced May 31, 2019

[standards] Make Flow configs use path-based imports instead of Haste #24812

Closed

[jest] Delete hasteImpl, providesModuleNodeModules, and modulePathNameMapper #24811

Closed

facebook-github-bot closed this in 69d1ed7 Jun 5, 2019

react-native-bot added the Merged This PR has been merged. label Jun 5, 2019

ide deleted the standard-paths-renderer branch April 25, 2020 08:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sync React with Haste-style imports rewritten to use path-based imports instead #25100

Sync React with Haste-style imports rewritten to use path-based imports instead #25100

ide commented May 31, 2019

cpojer left a comment

facebook-github-bot left a comment

react-native-bot commented Jun 5, 2019

Sync React with Haste-style imports rewritten to use path-based imports instead #25100

Sync React with Haste-style imports rewritten to use path-based imports instead #25100

Conversation

ide commented May 31, 2019

Summary

Changelog

Test Plan

cpojer left a comment

Choose a reason for hiding this comment

facebook-github-bot left a comment

Choose a reason for hiding this comment

react-native-bot commented Jun 5, 2019