Add indent for props generation of codegen #24438
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@zhongwuzw mind updating the snapshots? Looks like they show the changes pretty well :) |
|
@thymikee Ahha, I'll update. |
thymikee
approved these changes
Apr 13, 2019
facebook-github-bot
approved these changes
Apr 14, 2019
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @zhongwuzw in 2a4a9f8. When will my fix make it into a release? | Upcoming Releases |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 14, 2019
Summary: Part of #24438, add indent foe event emitter header codegen. cc. cpojer rickhanlonii. [General] [Fixed] - Add indent for event emitter header generation of codegen Pull Request resolved: #24445 Differential Revision: D14930352 Pulled By: cpojer fbshipit-source-id: 8bd03b8e12ccf9bd06546acdb744541fcb92eea1
|
Wow thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add correct indent when run codegen.
Before:
After:
cc. @cpojer @rickhanlonii
Changelog
[General] [Fixed] - Add indent for props generation of codegen
Test Plan
N/A.