bump gradle to 5.0, android gradle plugin to 3.3.1 (#23324)

dulmandakh · facebook-github-bot · commit b4017a9923b0 · 2019-02-20T11:42:54.000-08:00
Summary: This PR bumps gradle to 5.0, which includes Kotlin DSL 1.0, and android gradle plugin to 3.3.1, which includes includes various bug fixes and performance improvements. Also Gradle 5.x requires Java 8. This is preparation for Kotlin DSL migration. [Android] [Changed] - Bump Gradle to 5.0 Pull Request resolved: #23324 Reviewed By: mdvacca Differential Revision: D14028563 Pulled By: hramos fbshipit-source-id: 61fe1a2d4ea5707d6f07945acbd950f852420e13
diff --git a/build.gradle b/build.gradle
@@ -10,7 +10,7 @@ buildscript {
         jcenter()
     }
     dependencies {
-        classpath("com.android.tools.build:gradle:3.3.1")
+        classpath("com.android.tools.build:gradle:3.3.0")
         classpath("de.undercouch:gradle-download-task:3.4.3")
 
         // NOTE: Do not place your application dependencies here; they belong
diff --git a/gradle/wrapper/gradle-wrapper.jar b/gradle/wrapper/gradle-wrapper.jar
diff --git a/gradle/wrapper/gradle-wrapper.properties b/gradle/wrapper/gradle-wrapper.properties
@@ -1,7 +1,5 @@
-#Thu Jan 24 16:45:50 BRST 2019
 distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
+distributionUrl=https\://services.gradle.org/distributions/gradle-5.0-all.zip
 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-4.10.2-all.zip
-android.debug.obsoleteApi=true
diff --git a/template/android/build.gradle b/template/android/build.gradle
@@ -13,7 +13,7 @@ buildscript {
         jcenter()
     }
     dependencies {
-        classpath 'com.android.tools.build:gradle:3.3.1'
+        classpath 'com.android.tools.build:gradle:3.3.0'
 
         // NOTE: Do not place your application dependencies here; they belong
         // in the individual module build.gradle files
diff --git a/template/android/gradle/wrapper/gradle-wrapper.jar b/template/android/gradle/wrapper/gradle-wrapper.jar
diff --git a/template/android/gradle/wrapper/gradle-wrapper.properties b/template/android/gradle/wrapper/gradle-wrapper.properties
@@ -1,5 +1,5 @@
 distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
+distributionUrl=https\://services.gradle.org/distributions/gradle-5.0-all.zip
 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-4.10.2-all.zip

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ buildscript {`
`10`	`10`	`jcenter()`
`11`	`11`	`}`
`12`	`12`	`dependencies {`
`13`		`- classpath("com.android.tools.build:gradle:3.3.1")`
	`13`	`+ classpath("com.android.tools.build:gradle:3.3.0")`
`14`	`14`	`classpath("de.undercouch:gradle-download-task:3.4.3")`
`15`	`15`
`16`	`16`	`// NOTE: Do not place your application dependencies here; they belong`
Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@ buildscript {`
`13`	`13`	`jcenter()`
`14`	`14`	`}`
`15`	`15`	`dependencies {`
`16`		`- classpath 'com.android.tools.build:gradle:3.3.1'`
	`16`	`+ classpath 'com.android.tools.build:gradle:3.3.0'`
`17`	`17`
`18`	`18`	`// NOTE: Do not place your application dependencies here; they belong`
`19`	`19`	`// in the individual module build.gradle files`