add foreground prop in pressable ripple config #2728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for react-native ready! 🔨 Explore the source changes: e197d45 🔍 Inspect the deploy log: https://app.netlify.com/sites/react-native/deploys/611db27259ca290007c9dd76 😎 Browse the preview: https://deploy-preview-2728--react-native.netlify.app |
Simek
added
the
Wait on future Release
Simek
requested changes
Aug 17, 2021
There was a problem hiding this comment.
Hi @intergalacticspacehighway, thank you for updating the docs for RippleConfig! 👍
The addition looks fine, please fix the lint issue and the PR should be ready to merge. 🙂
Simek
approved these changes
Aug 19, 2021
There was a problem hiding this comment.
Hi @intergalacticspacehighway, thank you for the review update! 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds documentation for unreleased but merged foreground prop in Pressable facebook/react-native#31632