New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fwutil] Add missing new line to version prints #336

Open

aalamsi22 wants to merge 1 commit into facebook:main from aalamsi22:fw_util_version_printing

Contributor

aalamsi22 commented Feb 15, 2025

Description

fw_util version prints were missing a new line at the end. See the log below to explain

Pre fw_util new-line fix

[ ~]# fw_util --config_file=/opt/fboss/share/platform_configs/fw_util.json --fw_target_name=fan_cpld0 --fw_action=version
I0205 03:51:04.610634  3325 PlatformNameLib.cpp:73] Platform name read from cache: MERU800BFA
I0205 03:51:04.610693  3325 ConfigLib.cpp:33] Using config file: /opt/fboss/share/platform_configs/fw_util.json
fan_cpld0 : 1.2[ ~]# 
[ ~]#

After

[ ~]# fw_util --config_file=/opt/fboss/share/platform_configs/fw_util.json --fw_target_name=fan_cpld0 --fw_action=version
I0205 03:51:04.610634  3325 PlatformNameLib.cpp:73] Platform name read from cache: MERU800BFA
I0205 03:51:04.610693  3325 ConfigLib.cpp:33] Using config file: /opt/fboss/share/platform_configs/fw_util.json
fan_cpld0 : 1.2
[ ~]# 
[ ~]#


          Add missing new line to fw_util version prints

742fa28

facebook-github-bot added the CLA Signed label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels