allow TransformToNewSQ to be applied in TL modelbridge #3179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67156451 |
jelena-markovic
pushed a commit
to jelena-markovic/Ax
that referenced
this pull request
Dec 15, 2024
Summary: Enabling TransformToNewSQ to work for both target and source experiments with their own status quo and training data/observations. Since TL doesn't treat different trials within a single experiment as tasks we need to transform the trial data to be with respect to the same status quo. Reviewed By: saitcakmak Differential Revision: D67156451
jelena-markovic
force-pushed
the
export-D67156451
branch
from
4b55603 to
1528ffe
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67156451 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3179 +/- ##
==========================================
- Coverage 95.83% 95.83% -0.01%
==========================================
Files 505 505
Lines 50989 51008 +19
==========================================
+ Hits 48866 48884 +18
- Misses 2123 2124 +1 ☔ View full report in Codecov by Sentry. |
jelena-markovic
force-pushed
the
export-D67156451
branch
from
1528ffe to
0f837a1
Compare
jelena-markovic
pushed a commit
to jelena-markovic/Ax
that referenced
this pull request
Dec 16, 2024
Summary: Enabling TransformToNewSQ to work for both target and source experiments with their own status quo and training data/observations. Since TL doesn't treat different trials within a single experiment as tasks we need to transform the trial data to be with respect to the same status quo. Reviewed By: saitcakmak Differential Revision: D67156451
|
This pull request was exported from Phabricator. Differential Revision: D67156451 |
Summary: Enabling TransformToNewSQ to work for both target and source experiments with their own status quo and training data/observations. Since TL doesn't treat different trials within a single experiment as tasks we need to transform the trial data to be with respect to the same status quo. Reviewed By: saitcakmak Differential Revision: D67156451
jelena-markovic
force-pushed
the
export-D67156451
branch
from
0f837a1 to
757923f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67156451 |
|
This pull request has been merged in 151acd2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Enabling TransformToNewSQ to work for both target and source experiments with their own status quo and training data/observations. Since TL doesn't treat different trials within a single experiment as tasks we need to transform the trial data to be with respect to the same status quo.
Reviewed By: saitcakmak
Differential Revision: D67156451