fix TimeAsFeature transform for MOO #3178
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request was exported from Phabricator. Differential Revision: D67216689 |
Summary: see title. For MOO, fixed features can be empty in L931 in ax/modelbridge/torch.py. This led to an issue where `start_time` was not in the parameters dict, causing issues when untransforming. This fixes the issue Reviewed By: Balandat Differential Revision: D67216689
sdaulton
force-pushed
the
export-D67216689
branch
from
5892e7c to
5194333
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67216689 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3178 +/- ##
=======================================
Coverage 95.83% 95.83%
=======================================
Files 505 505
Lines 50989 50996 +7
=======================================
+ Hits 48866 48873 +7
Misses 2123 2123 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in c9303da. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: see title. For MOO, fixed features can be empty in L931 in ax/modelbridge/torch.py. This led to an issue where
start_timewas not in the parameters dict, causing issues when untransforming. This fixes the issueDifferential Revision: D67216689