Rewrite flaky test_compute for Interaction plot #3116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Unfortunately we cannot count the number of subplots present by taking the length of fig.data because data holds the *TRACES* not the subplots themselves, and each subplot may hold one or more traces. This was causing the test to be flaky. Instead now we are just checking that at least one trace came from a bar plot and that the other plots were either Scatter (slice) or Contour Reviewed By: paschai Differential Revision: D66472847
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66472847 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3116 +/- ##
=======================================
Coverage 95.43% 95.43%
=======================================
Files 503 503
Lines 50264 50279 +15
=======================================
+ Hits 47967 47982 +15
Misses 2297 2297 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in 454cb9a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Unfortunately we cannot count the number of subplots present by taking the length of fig.data because data holds the TRACES not the subplots themselves, and each subplot may hold one or more traces. This was causing the test to be flaky.
Instead now we are just checking that at least one trace came from a bar plot and that the other plots were either Scatter (slice) or Contour
Reviewed By: paschai
Differential Revision: D66472847