Simplify a benchmarking test function #3111
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66398976 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3111 +/- ##
==========================================
- Coverage 95.43% 95.42% -0.01%
==========================================
Files 503 503
Lines 50264 50269 +5
==========================================
+ Hits 47967 47970 +3
- Misses 2297 2299 +2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Nov 25, 2024
Summary: Simplified a function. I'm splitting off parts of D66313060 to make it easlier to review. I also removed some unused pyre-ignores (I'm not sure what changed). Reviewed By: Balandat Differential Revision: D66398976
esantorella
force-pushed
the
export-D66398976
branch
from
0859145 to
73a654c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66398976 |
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Nov 25, 2024
Summary: Simplified a function. I'm splitting off parts of D66313060 to make it easlier to review. I also removed some unused pyre-ignores (I'm not sure what changed). Reviewed By: Balandat Differential Revision: D66398976
…Function` a " n_steps" attribute (facebook#3110) Summary: Differentiating between step and time will be needed when we allow different steps to take different amounts of time. The new attribute is not needed yet, but will be in the next diff. This PR: * Changes docstring references to "time intervals" to "epochs" (now more sharply differentiating them from "virutal seconds") * Gives `BenchmarkTestProblem` an attribute `n_epochs` * Change the MapData key from "t" to "epoch" Differential Revision: D66397779
Summary: Simplified a function. I'm splitting off parts of D66313060 to make it easlier to review. I also removed some unused pyre-ignores (I'm not sure what changed). Reviewed By: Balandat Differential Revision: D66398976
esantorella
force-pushed
the
export-D66398976
branch
from
73a654c to
e610c84
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66398976 |
|
This pull request has been merged in e4cdeca. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Simplify a function. I'm splitting off parts of D66313060 to make it easlier to review.
Differential Revision: D66398976