Reap completion_criterion method #3092
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66245238 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3092 +/- ##
==========================================
- Coverage 95.42% 95.41% -0.01%
==========================================
Files 493 493
Lines 49949 49956 +7
==========================================
+ Hits 47662 47665 +3
- Misses 2287 2291 +4 ☔ View full report in Codecov by Sentry. |
paschai
added a commit
to paschai/Ax
that referenced
this pull request
Nov 25, 2024
Summary: As titled - this diff moves the logic from `completion_criterion` to `should_consider_optimization_complete` Cleanup tasks can be found in https://fburl.com/gdoc/xiet9m0v Differential Revision: D66245238
paschai
force-pushed
the
export-D66245238
branch
from
5fe40cc to
97461dd
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66245238 |
paschai
added a commit
to paschai/Ax
that referenced
this pull request
Nov 25, 2024
Summary: As titled - this diff moves the logic from `completion_criterion` to `should_consider_optimization_complete` Cleanup tasks can be found in https://fburl.com/gdoc/xiet9m0v Differential Revision: D66245238
paschai
force-pushed
the
export-D66245238
branch
from
97461dd to
c651311
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66245238 |
paschai
added a commit
to paschai/Ax
that referenced
this pull request
Nov 26, 2024
Summary: As titled - this diff moves the logic from `completion_criterion` to `should_consider_optimization_complete` Cleanup tasks can be found in https://fburl.com/gdoc/xiet9m0v Differential Revision: D66245238
paschai
force-pushed
the
export-D66245238
branch
from
c651311 to
31817a0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66245238 |
paschai
added a commit
to paschai/Ax
that referenced
this pull request
Nov 27, 2024
Summary: As titled - this diff moves the logic from `completion_criterion` to `should_consider_optimization_complete` Cleanup tasks can be found in https://fburl.com/gdoc/xiet9m0v Differential Revision: D66245238
paschai
force-pushed
the
export-D66245238
branch
from
31817a0 to
0f67475
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66245238 |
Summary: As titled - this diff moves the logic from `completion_criterion` to `should_consider_optimization_complete` Cleanup tasks can be found in https://fburl.com/gdoc/xiet9m0v Reviewed By: Balandat Differential Revision: D66245238
paschai
force-pushed
the
export-D66245238
branch
from
0f67475 to
378d4c0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66245238 |
|
This pull request has been merged in 9c58541. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
As titled - this diff moves the logic from
completion_criteriontoshould_consider_optimization_completeCleanup tasks can be found in https://fburl.com/gdoc/xiet9m0v
Differential Revision: D66245238