Use stable Rust to build and test aarch64-apple-darwin #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clauswilke
approved these changes
Jun 24, 2021
|
Let me figure out why the tests on aarch64-apple-darwin needed to be skipped... 🤔 |
|
Ah, of course setup-r action installs x86_64 version because macos-11 runner is (still?) on intel machines.
Sorry, my attempt was a bit too early. Let's wait for this: |
|
I minimized the change to just replacing the toolchain with the stable version. Let's revisit here when actions/runner-images#2187 gets ready... |
CGMossa
pushed a commit
to CGMossa/libR-sys
that referenced
this pull request
Jan 21, 2024
* Use stable Rust on macOS-11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the time of we added
macos-11runner, the nightly toolchain was needed. But, as of Rust 1.49,aarch64-apple-darwinis tier 2 target. This pull request adds the following changes regarding to this issue:Remove default targetRemove an workaround for duplication of the generated bindings