-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cross-compiling and precomputed bindings for Mac-aarch64 #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Could you also add a version of the bindings with R version removed from the name? The generic bindings are simply a copy of the most recent version-specific bindings. (Ideally I'd want to set this up as a symbolic link but those don't work well in git repos.) |
clauswilke
approved these changes
Dec 29, 2020
Thanks! I approve, so you can go ahead and merge. |
I'll wait for macos-11 test first before proceeding, thanks. |
This was referenced Jun 20, 2021
CGMossa
pushed a commit
to CGMossa/libR-sys
that referenced
this pull request
Jan 21, 2024
* Removed unused 'msystem' * Set up multiple targets * Enabling linux path * Running multiple tests * Correct handling of RUST_TARGETS and Windows support * Adding default MacOS * Fixed typo * Enabling other steps * Cleanup * Enabling all steps * Optional tests * Trying to fix libclang@Windows * Trying aarch with nightly rust * Cleanup & enabling all targets * Fixed MacOS rust version * Rearranging Macs & throwing if loop step fails * Attempting to fix MacOS path issue * Emitting bindings from rust-nightly * Improving error reporting * Testing aarch64 builds * Setting up MacOS environment vars * Fixed MacOS-11.0 dependencies' version * Tuning bindings upload condition * Reverting to rust-nightly * Added macos-aarch64 bindings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes 35.
aarch64
is only supported byrust-nightly
, so a separate VM with MacOS-11.0, R-release and rust-nightly is used to generate bindings.