Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-compiling and precomputed bindings for Mac-aarch64 #45

Merged
merged 26 commits into from
Dec 29, 2020

Conversation

Ilia-Kosenkov
Copy link
Member

@Ilia-Kosenkov Ilia-Kosenkov commented Dec 29, 2020

Partially fixes 35.
aarch64 is only supported by rust-nightly, so a separate VM with MacOS-11.0, R-release and rust-nightly is used to generate bindings.

@clauswilke
Copy link
Member

Could you also add a version of the bindings with R version removed from the name? The generic bindings are simply a copy of the most recent version-specific bindings. (Ideally I'd want to set this up as a symbolic link but those don't work well in git repos.)

@clauswilke
Copy link
Member

Thanks! I approve, so you can go ahead and merge.

@Ilia-Kosenkov
Copy link
Member Author

I'll wait for macos-11 test first before proceeding, thanks.

@Ilia-Kosenkov Ilia-Kosenkov merged commit bcacb42 into extendr:master Dec 29, 2020
CGMossa pushed a commit to CGMossa/libR-sys that referenced this pull request Jan 21, 2024
* Removed unused 'msystem'

* Set up multiple targets

* Enabling linux path

* Running multiple tests

* Correct handling of RUST_TARGETS and Windows support

* Adding default MacOS

* Fixed typo

* Enabling other steps

* Cleanup

* Enabling all steps

* Optional tests

* Trying to fix libclang@Windows

* Trying aarch with nightly rust

* Cleanup & enabling all targets

* Fixed MacOS rust version

* Rearranging Macs & throwing if loop step fails

* Attempting to fix MacOS path issue

* Emitting bindings from rust-nightly

* Improving error reporting

* Testing aarch64 builds

* Setting up MacOS environment vars

* Fixed MacOS-11.0 dependencies' version

* Tuning bindings upload condition

* Reverting to rust-nightly

* Added macos-aarch64 bindings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants