-
Notifications
You must be signed in to change notification settings - Fork 1.8k
i18n: new crowdin translations #1939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Need to change language code en to respective lang codes in files zh-cn/resources/contributing.md
, es/resources/contributing.md
.
47b5461
to
bcd537e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I was just testing something from Crowdin, it's what's causing the Spanish translations not to be pulled in
bcd537e
to
a4dd451
Compare
a4dd451
to
f91a186
Compare
New Crowdin translations from the express.js crowdin project. cc: @expressjs/docs-wg