Skip to content

Language picker: Add identifying feature and remove/fix duplicate nav ids #1804

Open
@chrisdel101

Description

@chrisdel101
Contributor

The language picker needs to be more distinguishable announcing it as a page feature and not just some text. As it is it just looks like text to me. Could be as simple as some kind of border, or fancier with an arrow

Image

Also it has duplicate ids to navbar. These should be replaced, or changed to classes if they are reusing styles.

  • Ids should not be duplicated in a codebase normally
  • it's very confusing to see these navbar and navmenu identifiers inside the picker like this.

Activity

chrisdel101

chrisdel101 commented on Feb 22, 2025

@chrisdel101
ContributorAuthor

Look like these issue are occurring in conjunction with #1780. Closing it for now since it's not appearing in the main branch after all. Will reopen later.

carlosstenzel

carlosstenzel commented on Mar 18, 2025

@carlosstenzel
Contributor

I like the idea of icons next to each language.

ShubhamOulkar

ShubhamOulkar commented on Mar 21, 2025

@ShubhamOulkar
Member

Duplicate ID resolved in PR #1833 for the desktop language picker. The mobile language picker is not resolved because I am doing an accessibility fix there. However, I believe we can use the same component on mobile devices to remove some JS and CSS.

@carlosstenzel , I decided not to add icons in pr #1833 because of system/browsers restrictions. Ofcourse we can use svgs but it is not top priority at the moment.

carlosstenzel

carlosstenzel commented on Mar 21, 2025

@carlosstenzel
Contributor

I think I could use SVG and hide it from mobile.

2 remaining items

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

designChange, update, or fix for site UI (not content)enhancement

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    Participants

    @carlosstenzel@chrisdel101@ShubhamOulkar@bjohansebas

    Issue actions

      Language picker: Add identifying feature and remove/fix duplicate nav ids · Issue #1804 · expressjs/expressjs.com