-
-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Settings includes values on Object.prototype #4802
Comments
Hi, yea, definitely a useless feature 😀 . I'd be happy to accept a fix; We could also make settings a null prototype object in the 5.0 branch. |
I'll make two changes:
Does that sound reasonable? If so, I can submit a patch. |
It sounds good, though I don't think you can just ignore any inherited value -- that is how the settings are inherited from parent apps to sub apps. |
Likely good enough to just filter out if it in |
Opened #4803. If that looks good, I'll make a similar PR for 5.0. |
Now that #4803 is merged, I'll plan to make a similar PR for the I hope to get to that in the next few days. |
Opened #4835. |
App settings pull from
Object.prototype
if they're missing on thesettings
object.Is this intentional? If not, I'm happy to help fix.
The text was updated successfully, but these errors were encountered: