Code

Refactor ACQF Optimization#535

Code

Draft

jduerholt wants to merge 33 commits intomainexperimental-design/bofire:mainfrom refactor/botorch._askexperimental-design/bofire:refactor/botorch._askCopy head branch name to clipboard

Commits

Commits on Mar 4, 2025

• refactorings and thoughts

  jduerholt

  committed
  5d3f792

  Copy full SHA for 5d3f792

Commits on Mar 7, 2025

• added structure for data-models for Optimizers

  LukasHebing

  committed
  adc7092

  Copy full SHA for adc7092

• after hooks

  LukasHebing

  committed
  4aea808

  Copy full SHA for 4aea808

• moved optimizer-dependent data-model fields, and validators

  LukasHebing

  committed
  8087f0d

  Copy full SHA for 8087f0d

• after hooks

  LukasHebing

  committed
  652dd0a

  Copy full SHA for 652dd0a

• moved descriptor/categorical/discrete method field from botorch strategy model, to botorch optimizer data-model

  LukasHebing

  committed
  389402d

  Copy full SHA for 389402d

• after hooks

  LukasHebing

  committed
  475d50f

  Copy full SHA for 475d50f

• moved data-model tests

  LukasHebing

  committed
  9bf473d

  Copy full SHA for 9bf473d

• renamed appearances of num... to n...

  LukasHebing

  committed
  1c4cadb

  Copy full SHA for 1c4cadb

• data-model tests run

  LukasHebing

  committed
  29d8b42

  Copy full SHA for 29d8b42

• after hooks

  LukasHebing

  committed
  dbd98a1

  Copy full SHA for dbd98a1

• included Optimizer mapping in mapper_actual.py

  LukasHebing

  committed
  7a9a5e3

  Copy full SHA for 7a9a5e3

• initialized optimizer in strategy __init__, using mapper function

  LukasHebing

  committed
  bf04ba8

  Copy full SHA for bf04ba8

• moved methods, WIP changing input structures

  LukasHebing

  committed
  d027dba

  Copy full SHA for d027dba

• WIP: moving methods to Optimizer

  LukasHebing

  committed
  3f5c817

  Copy full SHA for 3f5c817

• WIP

  LukasHebing

  committed
  36e7b21

  Copy full SHA for 36e7b21

Commits on Mar 10, 2025

• WIP: changing method signatures

  LukasHebing

  committed
  7825d69

  Copy full SHA for 7825d69

• after hooks

  LukasHebing

  committed
  a565033

  Copy full SHA for a565033

• some dubugging

  LukasHebing

  committed
  3ee0dbe

  Copy full SHA for 3ee0dbe

• after hooks

  LukasHebing

  committed
  6d4b777

  Copy full SHA for 6d4b777

• adapted (some) tests to acq. optimizer data model call

  LukasHebing

  committed
  4d8984f

  Copy full SHA for 4d8984f

Commits on Mar 11, 2025

• added testfile for optimizer

  LukasHebing

  committed
  709355b

  Copy full SHA for 709355b

• added strategy mapping for benchmark fixes

  LukasHebing

  committed
  1a0aada

  Copy full SHA for 1a0aada

• debugged: missing domain,... args in function calls

  LukasHebing

  committed
  b247cc0

  Copy full SHA for b247cc0

• after hooks

  LukasHebing

  committed
  0fa332d

  Copy full SHA for 0fa332d

Commits on Mar 13, 2025

• moved discrete optimization to Optimizer base class

  Show description for 5781d66
  LukasHebing

  committed
  5781d66

  Copy full SHA for 5781d66

• added categoric search to optimizer base-class

  LukasHebing

  committed
  60d9e46

  Copy full SHA for 60d9e46

• added test for all-categoric optimization (optimize_acqf_discrete)

  LukasHebing

  committed
  f08f9ad

  Copy full SHA for f08f9ad

• after hooks

  LukasHebing

  committed
  909809b

  Copy full SHA for 909809b

• removed commented test-cases

  LukasHebing

  committed
  f61236c

  Copy full SHA for f61236c

• added type-annotations

  LukasHebing

  committed
  5a0c1fd

  Copy full SHA for 5a0c1fd

• changed method "is_constraint_implemented" from classmethod to conventional method. For Bofire strategies, this matches to the same method on the optimizer

  LukasHebing

  committed
  76e9af4

  Copy full SHA for 76e9af4

• after hooks

  LukasHebing

  committed
  30ce1e8

  Copy full SHA for 30ce1e8