Adding a context manager for playback objects #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix install fail on recent python with python_version requirement * Add functions to access system timestamps for each image (etiennedub#122) * fix memory usage problem for calls to capture.transformed_ir (etiennedub#125) * version 1.2.4 Co-authored-by: Johan von Forstner <[email protected]>
Codecov Report
@@ Coverage Diff @@
## develop #130 +/- ##
===========================================
- Coverage 86.47% 86.15% -0.33%
===========================================
Files 10 10
Lines 710 715 +5
===========================================
+ Hits 614 616 +2
- Misses 96 99 +3
Continue to review full report at Codecov.
|
|
Hi and thank you for the PR! |
|
Yeah...I don't know why I didn't do my changes on develop to start with. Will update soon. |
rebase develop with master and merging develop back
|
Updated my branch. |
Merged
lpasselin
added a commit
that referenced
this pull request
Aug 7, 2021
* fix install fail on recent python with python_version requirement * Add functions to access system timestamps for each image (#122) * fix memory usage problem for calls to capture.transformed_ir (#125) * version 1.2.4 * Adding a context manager for playback objects (#130) * Added support for with statements Co-authored-by: David Dunn <[email protected]> * Windows sdk autodetection (#132) * Autodetecting Kinect SDK for windows * Fixes * Fixes * DLL Autodetection * Latest fixes * update version * rephrase readme * refactor and add K4A_DLL_DIR * minor readme change * rename loader to module * fix multiline string * Update module.py fix lint * Minor fix Co-authored-by: Louis-Philippe Asselin <[email protected]> * Add develop branch for ci target (#139) Co-authored-by: Johan von Forstner <[email protected]> Co-authored-by: Louis-Philippe Asselin <[email protected]> Co-authored-by: David Dunn <[email protected]> Co-authored-by: David Dunn <[email protected]> Co-authored-by: Ilya Gruzinov <[email protected]>
lpasselin
added a commit
that referenced
this pull request
Aug 7, 2021
* fix install fail on recent python with python_version requirement * Add functions to access system timestamps for each image (#122) * fix memory usage problem for calls to capture.transformed_ir (#125) * version 1.2.4 * Adding a context manager for playback objects (#130) * Added support for with statements Co-authored-by: David Dunn <[email protected]> * Windows sdk autodetection (#132) * Autodetecting Kinect SDK for windows * Fixes * Fixes * DLL Autodetection * Latest fixes * update version * rephrase readme * refactor and add K4A_DLL_DIR * minor readme change * rename loader to module * fix multiline string * Update module.py fix lint * Minor fix Co-authored-by: Louis-Philippe Asselin <[email protected]> * Add develop branch for ci target (#139) * rename 1.2.5 to 1.3.0 Co-authored-by: Johan von Forstner <[email protected]> Co-authored-by: Louis-Philippe Asselin <[email protected]> Co-authored-by: David Dunn <[email protected]> Co-authored-by: David Dunn <[email protected]> Co-authored-by: Ilya Gruzinov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With statements keep things tidy. So I added support for them in the playback object.