Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API token can be read from a log file by any user #9

Closed
fredriksvantes opened this issue Apr 15, 2022 · 2 comments
Closed

API token can be read from a log file by any user #9

fredriksvantes opened this issue Apr 15, 2022 · 2 comments
Labels
famed Famed - Tracked by Famed lighthouse medium Famed - Common Vulnerability Scoring System (CVSS) - Medium

Comments

@fredriksvantes
Copy link
Contributor

UID: CL-2021-38

Severity: medium

Type: BUG

Affected Clients: Lighthouse

Summary: A validator client uses two API keys: ".secp-sk" (secret key) and "api-token.txt" (the corresponding public key).
The spec suggests that an API token can be obtained (read) from a file or from logs.

The second method is highly insecure by design and considered as a very bad practice in web application security (e.g., OWASP Logging).

Moreover, an API token can be read from the log file by any user on the host because the file permissions for the logs are 644.

Links: sigp/lighthouse#2438

Reported: 2021-07-07

Fixed: 2021-09-13

Published: 2021-12-01

Bounty Hunter: Taurus

Bounty Points: Part of EF initiated Security Audit: https://arxiv.org/abs/2109.11684

@fredriksvantes fredriksvantes added famed Famed - Tracked by Famed medium Famed - Common Vulnerability Scoring System (CVSS) - Medium lighthouse labels Apr 15, 2022
@get-famed-eth
Copy link

get-famed-eth bot commented Apr 15, 2022

🤖 Assignees for Issue API token can be read from a log file by any user #9 are now eligible to Get Famed.

❌ Add assignees to track contribution times of the issue 🦸‍♀️🦹️
✅ Add a single severity (CVSS) label to compute the score 🏷️️

Happy hacking! 🦾💙❤️️

@get-famed-eth
Copy link

get-famed-eth bot commented May 24, 2022

Famed could not generate a reward suggestion.

Reason: The data provided by GitHub is not sufficient to generate a reward suggestion.
This might be due to an assignment after the issue has been closed. Please assign assignees in the open state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
famed Famed - Tracked by Famed lighthouse medium Famed - Common Vulnerability Scoring System (CVSS) - Medium
Projects
None yet
Development

No branches or pull requests

1 participant