Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(execution,fixtures): Labeled formats comparison #1233

Merged
merged 4 commits into from
Feb 19, 2025

Conversation

marioevz
Copy link
Member

@marioevz marioevz commented Feb 19, 2025

🗒️ Description

Fixes the following error:

================================================================ FAILURES ================================================================
__________________________ test_all_opcodes_in_container[fork_Osaka-blockchain_test_from_eof_test-opcode_STOP] ___________________________
tests/osaka/eip7692_eof_v1/eip3540_eof_v1/test_all_opcodes_in_container.py:115: in test_all_opcodes_in_container
    eof_test(
src/pytest_plugins/filler/filler.py:695: in __init__
    fixture = self.generate(
src/ethereum_test_specs/eof.py:464: in generate
    raise Exception(f"Unknown fixture format: {fixture_format}")
E   Exception: Unknown fixture format: <class 'ethereum_test_fixtures.blockchain.BlockchainFixture'>
============================================================ warnings summary ============================================================

Caused due to the comparison between the labeled fixture format and non-labeled ones during the fill process.

🔗 Related Issues

None

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@marioevz marioevz added type:bug Something isn't working scope:fw Scope: Framework (evm|tools|forks|pytest) labels Feb 19, 2025
Copy link
Collaborator

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marioevz marioevz merged commit 4bcea7f into main Feb 19, 2025
21 checks passed
@marioevz marioevz deleted the labeled-formats-comparison-fix branch February 19, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:fw Scope: Framework (evm|tools|forks|pytest) type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants