Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(tests): gas cost of delegation access in CALL #1208

Merged
merged 2 commits into from
Feb 14, 2025

Conversation

chfast
Copy link
Member

@chfast chfast commented Feb 12, 2025

🗒️ Description

Test additional cost of delegation contract access in call instructions.

This test can be extended to other call instructions and parametrized by the delegation contract being warm or cold.

🔗 Related Issues

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

Test additional cost of delegation contract access in call instructions.
@chfast chfast added the scope:tests Scope: Changes EL client test cases in `./tests` label Feb 12, 2025
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I've tested the suggestions locally and they are working, will commit and merge.

@marioevz marioevz merged commit e51cb1a into ethereum:main Feb 14, 2025
11 checks passed
@marioevz marioevz deleted the eip7702_call_delegation_gas_test branch February 14, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:tests Scope: Changes EL client test cases in `./tests`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants