Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass trace flag to state test process as a command line argument #543

Merged
merged 2 commits into from
Jan 12, 2023

Conversation

rodiazet
Copy link
Contributor

@rodiazet rodiazet commented Jan 2, 2023

No description provided.

@rodiazet rodiazet requested a review from chfast January 2, 2023 16:41
@rodiazet rodiazet requested a review from chfast January 2, 2023 19:25
@codecov
Copy link

codecov bot commented Jan 2, 2023

Codecov Report

Merging #543 (2527f44) into master (2515456) will increase coverage by 0.59%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #543      +/-   ##
==========================================
+ Coverage   97.37%   97.97%   +0.59%     
==========================================
  Files          63       63              
  Lines        6024     6031       +7     
==========================================
+ Hits         5866     5909      +43     
+ Misses        158      122      -36     
Flag Coverage Δ
blockchaintests 76.96% <ø> (ø)
statetests 73.32% <90.90%> (+0.17%) ⬆️
unittests 93.93% <100.00%> (+4.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/statetest/statetest.cpp 90.90% <100.00%> (-3.69%) ⬇️
lib/evmone/instructions.hpp 100.00% <0.00%> (+0.20%) ⬆️
test/state/precompiles.cpp 84.21% <0.00%> (+1.05%) ⬆️
lib/evmone/advanced_analysis.hpp 100.00% <0.00%> (+2.94%) ⬆️
test/statetest/statetest_loader.cpp 85.71% <0.00%> (+5.88%) ⬆️
test/state/host.cpp 87.56% <0.00%> (+7.02%) ⬆️
test/state/state.hpp 96.15% <0.00%> (+7.69%) ⬆️
test/state/state.cpp 88.50% <0.00%> (+9.19%) ⬆️
test/statetest/statetest_runner.cpp 93.75% <0.00%> (+12.50%) ⬆️
... and 1 more

@chfast chfast force-pushed the trace-command-param branch from 62644fc to c77441d Compare January 2, 2023 22:05
Copy link
Member

@chfast chfast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chfast chfast force-pushed the trace-command-param branch from c77441d to eebd0e1 Compare January 11, 2023 22:40
@chfast chfast force-pushed the trace-command-param branch from eebd0e1 to 2527f44 Compare January 12, 2023 09:32
@chfast chfast merged commit 7f6b2e6 into master Jan 12, 2023
@chfast chfast deleted the trace-command-param branch January 12, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants