Add EVMC_DELEGATED flag #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #720 +/- ##
=======================================
Coverage 93.41% 93.41%
=======================================
Files 26 26
Lines 3887 3887
Branches 404 404
=======================================
Hits 3631 3631
Misses 140 140
Partials 116 116 |
gumb0
force-pushed
the
delegated_flag
branch
2 times, most recently
from
f36f63b to
4f617bb
Compare
pdobacz
reviewed
Sep 19, 2024
gumb0
force-pushed
the
delegated_flag
branch
from
4f617bb to
08b8279
Compare
|
Let me review the 7702 implementation first. |
chfast
reviewed
Feb 3, 2025
| @@ -86,7 +86,8 @@ enum evmc_call_kind | |||
| /** The flags for ::evmc_message. */ | |||
| enum evmc_flags | |||
| { | |||
| EVMC_STATIC = 1 /**< Static call mode. */ | |||
| EVMC_STATIC = 1, /**< Static call mode. */ | |||
| EVMC_DELEGATED = 2 /**< Delegated call mode (EIP-7702). Valid since Prague. */ | |||
There was a problem hiding this comment.
Should we consider "designated" name?
There was a problem hiding this comment.
What do you mean? "Delegation designation" in the EIP refers to 0xef0100 || address string in account's code. Here the flag is about execution mode.
chfast
approved these changes
Feb 5, 2025
chfast
force-pushed
the
delegated_flag
branch
from
37b0084 to
fa053cf
Compare
chfast
added a commit
to ethereum/evmone
that referenced
this pull request
Feb 13, 2025
Implement [EIP-7702: Set EOA account code](https://eips.ethereum.org/EIPS/eip-7702). This EIP adds new transaction type _set-code_ that permanently sets the code delegation for an EOA. Requires new EVMC flag: ethereum/evmc#720.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for EIP-7702 implementation