Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-4750: Add Rationale section about "minimal" function type #9382

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

chfast
Copy link
Member

@chfast chfast commented Feb 19, 2025

No description provided.

@github-actions github-actions bot added c-update Modifies an existing proposal s-stagnant This EIP is Stagnant t-core labels Feb 19, 2025
@eth-bot
Copy link
Collaborator

eth-bot commented Feb 19, 2025

✅ All reviewers have approved.

@eth-bot eth-bot added the e-review Waiting on editor to review label Feb 19, 2025
@chfast chfast marked this pull request as ready for review February 20, 2025 10:21
@chfast chfast requested a review from eth-bot as a code owner February 20, 2025 10:21
@@ -133,6 +133,17 @@ Alternative logic for `RETF` in the top frame could be to allow it during code v

This has been superseded with the validation rule of top frame (0th code section) being non-returning (non-returning sections introduced in a separate EIP), because validating non-returning status of functions is valuable by itself for other reasons. Therefore all considerations of runtime behavior of `RETF` in the top frame were obsoleted.

### "Minimal" function type

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't want to convert this EIP from stagnant to draft or something?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do want.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should go back to Review, but I'm also doing it in #9386

@chfast chfast force-pushed the eip-4750-minimal-function-type branch from 30a34af to 28bc6c7 Compare March 10, 2025 14:02
@github-actions github-actions bot added s-review This EIP is in Review and removed s-stagnant This EIP is Stagnant labels Mar 10, 2025
@eth-bot eth-bot enabled auto-merge (squash) March 10, 2025 14:03
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit 2f3fb0c into ethereum:master Mar 10, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-update Modifies an existing proposal e-review Waiting on editor to review s-review This EIP is in Review t-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants