Hashrate printed per card. #225
Conversation
libstratum/EthStratumClientV2.cpp
Outdated
| p_farm->acceptedSolution(m_stale); | ||
| } | ||
| else { | ||
| cwarn << ":-( Not accepted."; | ||
| cwarn << EthRed << ":-( Not accepted."; |
libethcore/Miner.h
Outdated
| { | ||
| mh = _p.minerRate(i) / 1000000.0f; | ||
| sprintf(mhs, "%.2f", mh); | ||
| _out << " GPU" << gpuIndex++ << ": " << std::string(mhs) + "MH/s"; |
There was a problem hiding this comment.
Instead of using sprintf you can do:
<< std::fixed << std::setprecision(2) << mh << "MH/s";
libethcore/Miner.h
Outdated
| }; | ||
|
|
||
| inline std::ostream& operator<<(std::ostream& _out, WorkingProgress _p) | ||
| { | ||
| float mh = _p.rate() / 1000000.0f; | ||
| char mhs[16]; | ||
| sprintf(mhs, "%.2f", mh); | ||
| _out << std::string(mhs) + "MH/s"; | ||
| _out << "Total: " << std::string(mhs) + "MH/s"; |
There was a problem hiding this comment.
I'd prefer more condensed output. Maybe:
123.43 MH/s (5.13 54.12 12.00 8.01)
|
cwarn has a red background on the date, that's right :). I condensed the output, but left the GPU ID : I think it's better when we want to tweak the GPU settings to see the ID. I put in blue, in white it was not different enough from the hashrates. |
|
i was grab https://ci.appveyor.com/project/ethereum-mining/ethminer/build/307 to check "Properly reset text color after accepted shares." & for win 7 noo color, but i see build was not pass on 1 check |
|
Yes. All circleci checks have been failing for a few days, no idea why, I don't even know what it's checking :). For colors on windows, you need to have a look at #226. |
|
If you say "For colors on windows, you need to have a look at #226" then this change is for what ? only "Hashrate printed per card" what work on what S.O. & at what it refer then "Properly reset text color after accepted shares." ? |
|
One of the changes in this PR is to add green color to accepted shares line so it stands out. I forgot to reset it at the end of the line, so I added a new commit to fix it. However, colors only work on ANSI terminals, so if you want color on windows terminal which is not ANSI, you need #226. If you want both (hashrate per card + color on windows terminal), then you'll need to take both changes and compile yourself. |
|
k then if "green color to accepted shares" well that green color is not there at all & about that was my feedback & now when you was say exactly were i can confirm 100% is noo green color |
|
dear one when i ask about what S.O. it is supose to work this P.R. it was about what Sistem operation aka windows 8,7,10, linux, unix
|
|
I've been patient enough, and you are definitely right I'll stop losing my time after this post. I already said twice colors are not supported on windows, unless you take #226. And I mean all versions of Microsoft Windows, including Windows 7 and Windows 10. I don't know how to phrase it so it will be more clear to you, sorry. |
|
let me clarifies few think first you came & make some change / improvement (for what all & i am happy) what suppose to be good or bad & ppls like me or other to give you a feedback PR title Hashrate printed per card PR description I added hashrate per card, and colors for accepted/refused shares. aka is NO specifie any SO & if was say all this was avoid & noo confusion created ... |
|
Sorry if i drop in uninvited but ... I really do not understand this discussion about colors: IMHO colors are useful for those who like staring at their monitor continuosly while jumping on the seat for every share successfully submitted (probably shouting "Yuppie!"). On a headless mining rig this "feature" is completely unnecessary. |
|
CircleCI failures are not related. I'll have to fix it. |
|
Thank you for leaving the GPU ID. Combined with the Everything looks good and working well on linux. Thanks for the effort. |
I added hashrate per card, and colors for accepted/refused shares.