Skip to content
This repository was archived by the owner on Apr 24, 2022. It is now read-only.

Minor optimization and cleanup #1533

Merged
merged 1 commit into from
Sep 3, 2018
Merged

Minor optimization and cleanup #1533

merged 1 commit into from
Sep 3, 2018
+12 −15

Conversation

jean-m-cyr
Copy link
Contributor

  • Delete unnecessarily maintained variable
  • Allow the compiler the option to inline time
    critical method.

@jean-m-cyr
Minor optimization and cleanup

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
f529084 
- Delete unnecessarily maintained variable
- Allow the compiler the option to inline time
  critical method.
AndreaLanfranchi
AndreaLanfranchi approved these changes Sep 3, 2018
View reviewed changes
Copy link
Collaborator

@AndreaLanfranchi AndreaLanfranchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok but I would prefer to keep methods implementation in cpp files rather than in h files

@jean-m-cyr jean-m-cyr merged commit dc308cd into master Sep 3, 2018
@jean-m-cyr jean-m-cyr deleted the hr2 branch September 3, 2018 11:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chfast chfast

@AndreaLanfranchi AndreaLanfranchi

@ddobreff ddobreff

@StefanOberhumer StefanOberhumer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jean-m-cyr @chfast @AndreaLanfranchi