feat: add --port-by-serial option to filter ports by serial number #360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hfudev
reviewed
Jun 27, 2025
| @@ -203,6 +203,9 @@ def pytest_addoption(parser): | |||
| '--port-mac', | |||
| help='MAC address of the board. (Default: None)', | |||
| ) | |||
| esp_group.addoption( | |||
| '--port-by-serial', help='Comma-separated list of serial numbers to filter ports by. (Default: None)' | |||
There was a problem hiding this comment.
nitpick, better like the others use noun instead. for example, --port-serial-number?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This feature introduces a new CLI option
--port-by-serialthat allows users to filter ports based on a comma-separated list of serial numbers.esptooldependency to version 4.9.0.--port-by-serialargument to the CLI under theesp_group.filters['serials']field and passes it toesptool.get_port_list(**filters).Related
Closes #316
Testing
Checklist
Before submitting a Pull Request, please ensure the following: